Fimeg/Redflag
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Remove misleading TODO comment from handleUpdateAgent

Browse Source 
The TODO claimed update system was a "placeholder" but the code that
follows implements complete functionality:
- downloadUpdatePackage() downloads the package
- computeSHA256() verifies checksum
- verifyBinarySignature() with ed25519.Verify() checks signature
- installNewBinary() performs atomic installation
- Full rollback/cleanup with defer on failure

The comment was incorrect and misleading about the code quality.
This commit is contained in:
Fimeg
2025-12-19 22:30:19 -05:00
parent 2da93e442e
commit 54c554ac7c
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
aggregator-agent/cmd/agent/subsystem_handlers.go
View File

@@ -652,9 +652,6 @@ func handleUpdateAgent(apiClient *client.Client, cfg *config.Config, ackTracker
log.Printf("Failed to report update start log: %v\n", err) log.Printf("Failed to report update start log: %v\n", err)
} }
// TODO: Implement actual download, signature verification, and update installation
// This is a placeholder that simulates the update process
// Phase 5: Actual Ed25519-signed update implementation
log.Printf("Starting secure update process for version %s", version) log.Printf("Starting secure update process for version %s", version)
log.Printf("Download URL: %s", downloadURL) log.Printf("Download URL: %s", downloadURL)
log.Printf("Signature: %s...", signature[:16]) // Log first 16 chars of signature log.Printf("Signature: %s...", signature[:16]) // Log first 16 chars of signature