Fimeg/Redflag
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolve frontend approval error and add invalid command handling

Browse Source 
- Added missing approveMultiple function to updateApi
- Fixed API endpoint from /updates/bulk-approve to /updates/approve
- Enhanced invalid command handling in both Linux and Windows agents
- Agents now report unknown command types as failed commands back to server
This commit is contained in:
Fimeg
2025-11-01 21:56:31 -04:00
parent 3690472396
commit 99480f3fe3
2 changed files with 33 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
aggregator-agent/cmd/agent/main.go
View File

@@ -695,7 +695,20 @@ func runAgent(cfg *config.Config) error {
log.Printf("[Reboot] Error processing reboot command: %v\n", err)
}
default:
log.Printf("Unknown command type: %s\n", cmd.Type)
log.Printf("Unknown command type: %s - reporting as invalid command\n", cmd.Type)
// Report invalid command back to server
logReport := client.LogReport{
CommandID: cmd.ID,
Action: "process_command",
Result: "failed",
Stdout: "",
Stderr: fmt.Sprintf("Invalid command type: %s", cmd.Type),
ExitCode: 1,
DurationSeconds: 0,
}
if reportErr := reportLogWithAck(apiClient, cfg, ackTracker, logReport); reportErr != nil {
log.Printf("Failed to report invalid command result: %v", reportErr)
}
}
}

24
aggregator-agent/internal/service/windows.go
View File

@@ -209,16 +209,16 @@ func (s *redflagService) runAgent() {
}
}
if len(commands) == 0 {
if len(commands.Commands) == 0 {
log.Printf("Check-in successful - no new commands")
elog.Info(1, "Check-in successful - no new commands")
} else {
log.Printf("Check-in successful - received %d command(s)", len(commands))
elog.Info(1, fmt.Sprintf("Check-in successful - received %d command(s)", len(commands)))
log.Printf("Check-in successful - received %d command(s)", len(commands.Commands))
elog.Info(1, fmt.Sprintf("Check-in successful - received %d command(s)", len(commands.Commands)))
}
// Process each command with full implementation
for _, cmd := range commands {
for _, cmd := range commands.Commands {
log.Printf("Processing command: %s (%s)\n", cmd.Type, cmd.ID)
elog.Info(1, fmt.Sprintf("Processing command: %s (%s)", cmd.Type, cmd.ID))
@@ -256,8 +256,22 @@ func (s *redflagService) runAgent() {
elog.Error(1, fmt.Sprintf("Error disabling heartbeat: %v", err))
}
default:
log.Printf("Unknown command type: %s\n", cmd.Type)
log.Printf("Unknown command type: %s - reporting as invalid command\n", cmd.Type)
elog.Error(1, fmt.Sprintf("Unknown command type: %s", cmd.Type))
// Report invalid command back to server
logReport := client.LogReport{
CommandID: cmd.ID,
Action: "process_command",
Result: "failed",
Stdout: "",
Stderr: fmt.Sprintf("Invalid command type: %s", cmd.Type),
ExitCode: 1,
DurationSeconds: 0,
}
if reportErr := apiClient.ReportLog(s.agent.AgentID, logReport); reportErr != nil {
log.Printf("Failed to report invalid command result: %v", reportErr)
elog.Error(1, fmt.Sprintf("Failed to report invalid command result: %v", reportErr))
}
}
}