3 Commits

Author	SHA1	Message	Date
jpetree331	ec0d880036	fix(database): B-1 schema integrity and migration fixes ... - Fix migration 024 self-insert and bad column reference (F-B1-1, F-B1-2) Uses existing enabled/auto_run columns instead of non-existent deprecated - Abort server on migration failure instead of warning (F-B1-11) main.go now calls log.Fatalf, prints [INFO] only on success - Fix migration 018 scanner_config filename suffix (F-B1-3) Renumbered to 027 with .up.sql suffix - Remove GRANT to non-existent role in scanner_config (F-B1-4) - Resolve duplicate migration numbers 009 and 012 (F-B1-13) Renamed to 009b and 012b for unique lexical sorting - Add IF NOT EXISTS to all non-idempotent migrations (F-B1-15) Fixed: 011, 012, 017, 023, 023a - Replace N+1 dashboard stats loop with GetAllUpdateStats (F-B1-6) Single aggregate query replaces per-agent loop - Add composite index on agent_commands(status, sent_at) (F-B1-5) New migration 028 with partial index for timeout service - Add background refresh token cleanup goroutine (F-B1-10) 24-hour ticker calls CleanupExpiredTokens - ETHOS log format in migration runner (no emojis) All 55 tests pass (41 server + 14 agent). No regressions. See docs/B1_Fix_Implementation.md and DEV-025 through DEV-028. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-03-29 07:03:35 -04:00
jpetree331	ab676c3b83	test(database): B-1 pre-fix tests for migration and schema bugs ... Pre-fix test suite documenting 9 database migration and schema integrity bugs. Tests FAIL where they assert correct post-fix behavior, PASS where they document current buggy state. Tests added: - F-B1-11 P0: main.go swallows migration errors (3 tests) - F-B1-13: Duplicate migration numbers 009/012 (2 tests) - F-B1-1: Migration 024 self-insert into schema_migrations (2 tests) - F-B1-2: Migration 024 references non-existent column (2 tests) - F-B1-3: Migration 018 wrong file suffix (2 tests) - F-B1-4: Migration 018 GRANT to wrong role (1 test) - F-B1-15: 7+ migrations not idempotent (2 tests) - F-B1-5: Missing agent_commands sent_at index (2 tests) - F-B1-6: N+1 query in GetDashboardStats (2 tests) - F-B1-10: No background refresh token cleanup (2 tests) Current state: 10 PASS, 10 FAIL, 0 SKIP. All A-series tests continue to pass (no regressions). See docs/B1_PreFix_Tests.md for full inventory. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-03-29 06:42:19 -04:00
jpetree331	f97d4845af	feat(security): A-1 Ed25519 key rotation + A-2 replay attack fixes ... Complete RedFlag codebase with two major security audit implementations. == A-1: Ed25519 Key Rotation Support == Server: - SignCommand sets SignedAt timestamp and KeyID on every signature - signing_keys database table (migration 020) for multi-key rotation - InitializePrimaryKey registers active key at startup - /api/v1/public-keys endpoint for rotation-aware agents - SigningKeyQueries for key lifecycle management Agent: - Key-ID-aware verification via CheckKeyRotation - FetchAndCacheAllActiveKeys for rotation pre-caching - Cache metadata with TTL and staleness fallback - SecurityLogger events for key rotation and command signing == A-2: Replay Attack Fixes (F-1 through F-7) == F-5 CRITICAL - RetryCommand now signs via signAndCreateCommand F-1 HIGH - v3 format: "{agent_id}:{cmd_id}:{type}:{hash}:{ts}" F-7 HIGH - Migration 026: expires_at column with partial index F-6 HIGH - GetPendingCommands/GetStuckCommands filter by expires_at F-2 HIGH - Agent-side executedIDs dedup map with cleanup F-4 HIGH - commandMaxAge reduced from 24h to 4h F-3 CRITICAL - Old-format commands rejected after 48h via CreatedAt Verification fixes: migration idempotency (ETHOS #4), log format compliance (ETHOS #1), stale comments updated. All 24 tests passing. Docker --no-cache build verified. See docs/ for full audit reports and deviation log (DEV-001 to DEV-019). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-03-28 21:25:47 -04:00