6b3ab6d6fc
BREAKING CHANGE: Storage and system scans no longer create entries in update_logs **Problem** - Storage scans were appearing on Updates page (mixed with package updates) - System scans were appearing on Updates page (mixed with package updates) - Duplicate "Scan All" entries from collective + individual logging **Root Cause** Scan handlers were calling both ReportLog() and dedicated endpoints: - reportLogWithAck → POST /api/v1/agents/:id/logs → update_logs table - This caused storage/system metrics to appear alongside package updates **Fix** Removed ALL ReportLog() calls from scan handlers: 1. handleScanUpdatesV2 (lines 44-46): Removed collective logging 2. handleScanStorage (lines 103-105): Use only ReportStorageMetrics 3. handleScanSystem (lines 189-191): Use only ReportMetrics 4. handleScanDocker (lines 269-271): Use only ReportDockerImages **Verification** - All 4 handlers have working dedicated endpoints (verified via subagent) - Routes already registered: POST /storage-metrics, POST /metrics, etc. - Frontend queries correct endpoints (verified) - No data loss: dedicated endpoints store in proper tables **Result** - Storage scans → storage_metrics table → Storage page only ✅ - System scans → system reporting → System page only ✅ - Package updates → update_logs table → Updates page only ✅ - No duplicate "Scan All" entries ✅ **Files Changed** - aggregator-agent/cmd/agent/subsystem_handlers.go: Removed 20 lines of ReportLog calls - internal/api/handlers/agents.go: Command recovery enhancements - internal/api/handlers/updates.go: Subsystem extraction logic - internal/database/queries/commands.go: GetStuckCommands query
56 lines
1.8 KiB
Go
56 lines
1.8 KiB
Go
package validator
|
|
|
|
import (
|
|
"fmt"
|
|
)
|
|
|
|
// IntervalValidator provides bounds checking for agent and scanner intervals
|
|
type IntervalValidator struct {
|
|
minCheckInSeconds int // 60 seconds (1 minute)
|
|
maxCheckInSeconds int // 3600 seconds (1 hour)
|
|
minScannerMinutes int // 1 minute
|
|
maxScannerMinutes int // 1440 minutes (24 hours)
|
|
}
|
|
|
|
// NewIntervalValidator creates a validator with default bounds
|
|
func NewIntervalValidator() *IntervalValidator {
|
|
return &IntervalValidator{
|
|
minCheckInSeconds: 60, // 1 minute minimum
|
|
maxCheckInSeconds: 3600, // 1 hour maximum
|
|
minScannerMinutes: 1, // 1 minute minimum
|
|
maxScannerMinutes: 1440, // 24 hours maximum
|
|
}
|
|
}
|
|
|
|
// ValidateCheckInInterval checks if agent check-in interval is within bounds
|
|
func (v *IntervalValidator) ValidateCheckInInterval(seconds int) error {
|
|
if seconds < v.minCheckInSeconds {
|
|
return fmt.Errorf("check-in interval %d seconds below minimum %d seconds (1 minute)",
|
|
seconds, v.minCheckInSeconds)
|
|
}
|
|
if seconds > v.maxCheckInSeconds {
|
|
return fmt.Errorf("check-in interval %d seconds above maximum %d seconds (1 hour)",
|
|
seconds, v.maxCheckInSeconds)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// ValidateScannerInterval checks if scanner interval is within bounds
|
|
func (v *IntervalValidator) ValidateScannerInterval(minutes int) error {
|
|
if minutes < v.minScannerMinutes {
|
|
return fmt.Errorf("scanner interval %d minutes below minimum %d minutes",
|
|
minutes, v.minScannerMinutes)
|
|
}
|
|
if minutes > v.maxScannerMinutes {
|
|
return fmt.Errorf("scanner interval %d minutes above maximum %d minutes (24 hours)",
|
|
minutes, v.maxScannerMinutes)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// GetBounds returns the current validation bounds (for testing/monitoring)
|
|
func (v *IntervalValidator) GetBounds() (minCheckIn, maxCheckIn, minScanner, maxScanner int) {
|
|
return v.minCheckInSeconds, v.maxCheckInSeconds,
|
|
v.minScannerMinutes, v.maxScannerMinutes
|
|
}
|