Redflag/aggregator-server/internal/database/migrations/migration018_test.go

package migrations_test

// migration018_test.go — Pre-fix tests for migration 018 filename bug.
//
// F-B1-3 HIGH: 018_create_scanner_config_table.sql has no .up.sql suffix.
//   The migration runner only processes *.up.sql files (db.go:59).
//   scanner_config table is NEVER created by the migration runner.
//
// F-B1-4 HIGH: GRANT references role `redflag_user` which does not exist.
//   The default database user is `redflag`.
//
// Run: cd aggregator-server && go test ./internal/database/migrations/... -v -run TestMigration018

import (
	"os"
	"strings"
	"testing"
)

// ---------------------------------------------------------------------------
// Test 3.1 — scanner_config migration has wrong file suffix (documents F-B1-3)
//
// Category: PASS-NOW (documents the bug)
// ---------------------------------------------------------------------------

func TestMigration018ScannerConfigHasWrongSuffix(t *testing.T) {
	files, err := os.ReadDir(".")
	if err != nil {
		t.Fatalf("failed to read migrations directory: %v", err)
	}

	hasWrongSuffix := false
	hasCorrectSuffix := false

	for _, f := range files {
		if f.Name() == "018_create_scanner_config_table.sql" {
			hasWrongSuffix = true
		}
		if f.Name() == "018_create_scanner_config_table.up.sql" {
			hasCorrectSuffix = true
		}
	}

	if !hasWrongSuffix {
		t.Error("[ERROR] [server] [database] F-B1-3 already fixed: " +
			"018_create_scanner_config_table.sql no longer exists")
	}
	if hasCorrectSuffix {
		t.Error("[ERROR] [server] [database] F-B1-3 already fixed: " +
			"018_create_scanner_config_table.up.sql now exists")
	}

	t.Log("[INFO] [server] [database] F-B1-3 confirmed: scanner_config migration has .sql suffix (not .up.sql)")
	t.Log("[INFO] [server] [database] the migration runner skips this file; scanner_config table is never created")
}

// ---------------------------------------------------------------------------
// Test 3.2 — scanner_config migration should have correct suffix (assert fix)
//
// Category: FAIL-NOW / PASS-AFTER-FIX
// ---------------------------------------------------------------------------

func TestMigration018ScannerConfigHasCorrectSuffix(t *testing.T) {
	files, err := os.ReadDir(".")
	if err != nil {
		t.Fatalf("failed to read migrations directory: %v", err)
	}

	found := false
	for _, f := range files {
		if f.Name() == "018_create_scanner_config_table.up.sql" {
			found = true
			break
		}
	}

	if !found {
		t.Errorf("[ERROR] [server] [database] 018_create_scanner_config_table.up.sql not found.\n"+
			"F-B1-3: scanner_config migration must have .up.sql suffix for the runner to process it.\n"+
			"After fix: rename 018_create_scanner_config_table.sql to 018_create_scanner_config_table.up.sql")
	}
}

// ---------------------------------------------------------------------------
// Test 3.3 — scanner_config migration should not GRANT to wrong role (F-B1-4)
//
// Category: FAIL-NOW / PASS-AFTER-FIX
// ---------------------------------------------------------------------------

func TestMigration018ScannerConfigHasNoGrantToWrongRole(t *testing.T) {
	// Try both possible filenames
	var content []byte
	var err error

	content, err = os.ReadFile("018_create_scanner_config_table.up.sql")
	if err != nil {
		content, err = os.ReadFile("018_create_scanner_config_table.sql")
		if err != nil {
			t.Fatalf("failed to read scanner_config migration (tried both suffixes): %v", err)
		}
	}

	src := string(content)

	if strings.Contains(src, "redflag_user") {
		t.Errorf("[ERROR] [server] [database] scanner_config migration GRANTs to non-existent role `redflag_user`.\n"+
			"F-B1-4: the default database user is `redflag`, not `redflag_user`.\n"+
			"After fix: use correct role name or remove the GRANT statement.")
	}
}