Complete RedFlag codebase with two major security audit implementations.
== A-1: Ed25519 Key Rotation Support ==
Server:
- SignCommand sets SignedAt timestamp and KeyID on every signature
- signing_keys database table (migration 020) for multi-key rotation
- InitializePrimaryKey registers active key at startup
- /api/v1/public-keys endpoint for rotation-aware agents
- SigningKeyQueries for key lifecycle management
Agent:
- Key-ID-aware verification via CheckKeyRotation
- FetchAndCacheAllActiveKeys for rotation pre-caching
- Cache metadata with TTL and staleness fallback
- SecurityLogger events for key rotation and command signing
== A-2: Replay Attack Fixes (F-1 through F-7) ==
F-5 CRITICAL - RetryCommand now signs via signAndCreateCommand
F-1 HIGH - v3 format: "{agent_id}:{cmd_id}:{type}:{hash}:{ts}"
F-7 HIGH - Migration 026: expires_at column with partial index
F-6 HIGH - GetPendingCommands/GetStuckCommands filter by expires_at
F-2 HIGH - Agent-side executedIDs dedup map with cleanup
F-4 HIGH - commandMaxAge reduced from 24h to 4h
F-3 CRITICAL - Old-format commands rejected after 48h via CreatedAt
Verification fixes: migration idempotency (ETHOS #4), log format
compliance (ETHOS #1), stale comments updated.
All 24 tests passing. Docker --no-cache build verified.
See docs/ for full audit reports and deviation log (DEV-001 to DEV-019).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
59 lines
1.4 KiB
Go
59 lines
1.4 KiB
Go
package utils
|
|
|
|
import (
|
|
"strconv"
|
|
"strings"
|
|
)
|
|
|
|
// CompareVersions compares two semantic version strings
|
|
// Returns:
|
|
// -1 if version1 < version2
|
|
// 0 if version1 == version2
|
|
// 1 if version1 > version2
|
|
func CompareVersions(version1, version2 string) int {
|
|
// Parse version strings (expected format: "0.1.4")
|
|
v1Parts := parseVersion(version1)
|
|
v2Parts := parseVersion(version2)
|
|
|
|
// Compare major, minor, patch versions
|
|
for i := 0; i < 3; i++ {
|
|
if v1Parts[i] < v2Parts[i] {
|
|
return -1
|
|
}
|
|
if v1Parts[i] > v2Parts[i] {
|
|
return 1
|
|
}
|
|
}
|
|
|
|
return 0
|
|
}
|
|
|
|
// IsNewerVersion returns true if version1 is newer than version2
|
|
func IsNewerVersion(version1, version2 string) bool {
|
|
return CompareVersions(version1, version2) == 1
|
|
}
|
|
|
|
// IsNewerOrEqualVersion returns true if version1 is newer than or equal to version2
|
|
func IsNewerOrEqualVersion(version1, version2 string) bool {
|
|
cmp := CompareVersions(version1, version2)
|
|
return cmp == 1 || cmp == 0
|
|
}
|
|
|
|
// parseVersion parses a version string like "0.1.4" into [0, 1, 4]
|
|
func parseVersion(version string) [3]int {
|
|
// Default version if parsing fails
|
|
result := [3]int{0, 0, 0}
|
|
|
|
// Remove any 'v' prefix and split by dots
|
|
cleanVersion := strings.TrimPrefix(version, "v")
|
|
parts := strings.Split(cleanVersion, ".")
|
|
|
|
// Parse each part, defaulting to 0 if parsing fails
|
|
for i := 0; i < len(parts) && i < 3; i++ {
|
|
if num, err := strconv.Atoi(parts[i]); err == nil {
|
|
result[i] = num
|
|
}
|
|
}
|
|
|
|
return result
|
|
} |