Files
Redflag/aggregator-server/internal/api/handlers/agent_updates.go
Fimeg 1f2b1b7179 fix: repair version detection platform query format
- Fix GetLatestVersionByTypeAndArch to separate platform/architecture
- Query now correctly uses platform='linux' and architecture='amd64'
- Resolves UI showing 'no packages available' despite updates existing
2025-11-10 20:11:32 -05:00

680 lines
21 KiB
Go

package handlers
import (
"fmt"
"log"
"net/http"
"os"
"strconv"
"strings"
"time"
"github.com/Fimeg/RedFlag/aggregator-server/internal/database/queries"
"github.com/Fimeg/RedFlag/aggregator-server/internal/models"
"github.com/Fimeg/RedFlag/aggregator-server/internal/services"
"github.com/gin-gonic/gin"
"github.com/google/uuid"
)
type AgentUpdateHandler struct {
agentQueries *queries.AgentQueries
agentUpdateQueries *queries.AgentUpdateQueries
commandQueries *queries.CommandQueries
signingService *services.SigningService
nonceService *services.UpdateNonceService
agentHandler *AgentHandler
}
// NewAgentUpdateHandler creates a new agent update handler
func NewAgentUpdateHandler(aq *queries.AgentQueries, auq *queries.AgentUpdateQueries, cq *queries.CommandQueries, ss *services.SigningService, ns *services.UpdateNonceService, ah *AgentHandler) *AgentUpdateHandler {
return &AgentUpdateHandler{
agentQueries: aq,
agentUpdateQueries: auq,
commandQueries: cq,
signingService: ss,
nonceService: ns,
agentHandler: ah,
}
}
// UpdateAgent handles POST /api/v1/agents/:id/update (manual agent update)
func (h *AgentUpdateHandler) UpdateAgent(c *gin.Context) {
// Extract agent ID from URL path
agentID := c.Param("id")
if agentID == "" {
c.JSON(http.StatusBadRequest, gin.H{"error": "agent ID is required"})
return
}
// Debug logging for development (controlled via REDFLAG_DEBUG env var or query param)
debugMode := os.Getenv("REDFLAG_DEBUG") == "true" || c.Query("debug") == "true"
if debugMode {
log.Printf("[DEBUG] [UpdateAgent] Starting update request for agent %s from %s", agentID, c.ClientIP())
log.Printf("[DEBUG] [UpdateAgent] Content-Type: %s, Content-Length: %d", c.ContentType(), c.Request.ContentLength)
}
var req models.AgentUpdateRequest
if err := c.ShouldBindJSON(&req); err != nil {
if debugMode {
log.Printf("[DEBUG] [UpdateAgent] JSON binding error for agent %s: %v", agentID, err)
}
c.JSON(http.StatusBadRequest, gin.H{
"error": err.Error(),
"_error_context": "json_binding_failed", // Helps identify binding vs validation errors
})
return
}
// Always log critical update operations for audit trail
log.Printf("[UPDATE] Agent %s received update request - Version: %s, Platform: %s", agentID, req.Version, req.Platform)
// Debug: Log the parsed request
if debugMode {
log.Printf("[DEBUG] [UpdateAgent] Parsed update request - Version: %s, Platform: %s, Nonce: %s", req.Version, req.Platform, req.Nonce)
}
agentIDUUID, err := uuid.Parse(agentID)
if err != nil {
log.Printf("[UPDATE] Agent ID format error for %s: %v", agentID, err)
c.JSON(http.StatusBadRequest, gin.H{"error": "invalid agent ID format"})
return
}
// Verify the agent exists
agent, err := h.agentQueries.GetAgentByID(agentIDUUID)
if err != nil {
c.JSON(http.StatusNotFound, gin.H{"error": "agent not found"})
return
}
// Check if agent is already updating
if agent.IsUpdating {
c.JSON(http.StatusConflict, gin.H{
"error": "agent is already updating",
"current_update": agent.UpdatingToVersion,
"initiated_at": agent.UpdateInitiatedAt,
})
return
}
// Validate platform compatibility
if !h.isPlatformCompatible(agent, req.Platform) {
c.JSON(http.StatusBadRequest, gin.H{
"error": fmt.Sprintf("platform %s is not compatible with agent %s/%s",
req.Platform, agent.OSType, agent.OSArchitecture),
})
return
}
// Get the update package
pkg, err := h.agentUpdateQueries.GetUpdatePackageByVersion(req.Version, req.Platform, agent.OSArchitecture)
if err != nil {
c.JSON(http.StatusNotFound, gin.H{"error": fmt.Sprintf("update package not found: %v", err)})
return
}
// Update agent status to "updating"
if err := h.agentQueries.UpdateAgentUpdatingStatus(agentIDUUID, true, &req.Version); err != nil {
log.Printf("Failed to update agent %s status to updating: %v", agentID, err)
c.JSON(http.StatusInternalServerError, gin.H{"error": "failed to initiate update"})
return
}
// Validate the provided nonce
if h.nonceService != nil {
if debugMode {
log.Printf("[DEBUG] [UpdateAgent] Validating nonce for agent %s: %s", agentID, req.Nonce)
}
verifiedNonce, err := h.nonceService.Validate(req.Nonce)
if err != nil {
h.agentQueries.UpdateAgentUpdatingStatus(agentIDUUID, false, nil) // Rollback
log.Printf("[UPDATE] Nonce validation failed for agent %s: %v", agentID, err)
// Include specific error context for debugging
errorType := "signature_verification_failed"
if err.Error() == "nonce expired" {
errorType = "nonce_expired"
} else if err.Error() == "invalid base64" {
errorType = "invalid_nonce_format"
}
c.JSON(http.StatusBadRequest, gin.H{
"error": "invalid update nonce: " + err.Error(),
"_error_context": errorType,
"_error_detail": err.Error(),
})
return
}
if debugMode {
log.Printf("[DEBUG] [UpdateAgent] Nonce verified - AgentID: %s, TargetVersion: %s", verifiedNonce.AgentID, verifiedNonce.TargetVersion)
}
// Verify the nonce matches the requested agent and version
if verifiedNonce.AgentID != agentID {
if debugMode {
log.Printf("[DEBUG] [UpdateAgent] Agent ID mismatch - nonce: %s, URL: %s", verifiedNonce.AgentID, agentID)
}
log.Printf("[UPDATE] Agent ID mismatch in nonce: expected %s, got %s", agentID, verifiedNonce.AgentID)
h.agentQueries.UpdateAgentUpdatingStatus(agentIDUUID, false, nil) // Rollback
c.JSON(http.StatusBadRequest, gin.H{
"error": "nonce agent ID mismatch",
"_agent_id": agentID,
"_nonce_agent_id": verifiedNonce.AgentID,
})
return
}
if verifiedNonce.TargetVersion != req.Version {
if debugMode {
log.Printf("[DEBUG] [UpdateAgent] Version mismatch - nonce: %s, request: %s", verifiedNonce.TargetVersion, req.Version)
}
log.Printf("[UPDATE] Version mismatch in nonce: expected %s, got %s", req.Version, verifiedNonce.TargetVersion)
h.agentQueries.UpdateAgentUpdatingStatus(agentIDUUID, false, nil) // Rollback
c.JSON(http.StatusBadRequest, gin.H{
"error": "nonce version mismatch",
"_requested_version": req.Version,
"_nonce_version": verifiedNonce.TargetVersion,
})
return
}
log.Printf("[UPDATE] Nonce successfully validated for agent %s to version %s", agentID, req.Version)
}
// Generate nonce for replay protection
nonceUUID := uuid.New()
nonceTimestamp := time.Now()
var nonceSignature string
if h.signingService != nil {
var err error
nonceSignature, err = h.signingService.SignNonce(nonceUUID, nonceTimestamp)
if err != nil {
log.Printf("Failed to sign nonce: %v", err)
h.agentQueries.UpdateAgentUpdatingStatus(req.AgentID, false, nil) // Rollback
c.JSON(http.StatusInternalServerError, gin.H{"error": "failed to sign nonce"})
return
}
}
// Create update command for agent
commandType := "update_agent"
commandParams := map[string]interface{}{
"version": req.Version,
"platform": req.Platform,
"download_url": fmt.Sprintf("/api/v1/downloads/updates/%s", pkg.ID),
"signature": pkg.Signature,
"checksum": pkg.Checksum,
"file_size": pkg.FileSize,
"nonce_uuid": nonceUUID.String(),
"nonce_timestamp": nonceTimestamp.Format(time.RFC3339),
"nonce_signature": nonceSignature,
}
// Schedule the update if requested
if req.Scheduled != nil {
scheduledTime, err := time.Parse(time.RFC3339, *req.Scheduled)
if err != nil {
h.agentQueries.UpdateAgentUpdatingStatus(req.AgentID, false, nil) // Rollback
c.JSON(http.StatusBadRequest, gin.H{"error": "invalid scheduled time format"})
return
}
commandParams["scheduled_at"] = scheduledTime
}
// Create the command in database
command := &models.AgentCommand{
ID: uuid.New(),
AgentID: req.AgentID,
CommandType: commandType,
Params: commandParams,
Status: models.CommandStatusPending,
Source: "web_ui",
CreatedAt: time.Now(),
}
if err := h.commandQueries.CreateCommand(command); err != nil {
// Rollback the updating status
h.agentQueries.UpdateAgentUpdatingStatus(req.AgentID, false, nil)
log.Printf("Failed to create update command for agent %s: %v", req.AgentID, err)
c.JSON(http.StatusInternalServerError, gin.H{"error": "failed to create command"})
return
}
log.Printf("✅ Agent update initiated for %s: %s (%s)", agent.Hostname, req.Version, req.Platform)
response := models.AgentUpdateResponse{
Message: "Update initiated successfully",
UpdateID: command.ID.String(),
DownloadURL: fmt.Sprintf("/api/v1/downloads/updates/%s", pkg.ID),
Signature: pkg.Signature,
Checksum: pkg.Checksum,
FileSize: pkg.FileSize,
EstimatedTime: h.estimateUpdateTime(pkg.FileSize),
}
c.JSON(http.StatusOK, response)
}
// BulkUpdateAgents handles POST /api/v1/agents/bulk-update (bulk agent update)
func (h *AgentUpdateHandler) BulkUpdateAgents(c *gin.Context) {
var req models.BulkAgentUpdateRequest
if err := c.ShouldBindJSON(&req); err != nil {
c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
return
}
if len(req.AgentIDs) == 0 {
c.JSON(http.StatusBadRequest, gin.H{"error": "no agent IDs provided"})
return
}
if len(req.AgentIDs) > 50 {
c.JSON(http.StatusBadRequest, gin.H{"error": "too many agents in bulk update (max 50)"})
return
}
// Get the update package first to validate it exists
pkg, err := h.agentUpdateQueries.GetUpdatePackageByVersion(req.Version, req.Platform, "")
if err != nil {
c.JSON(http.StatusNotFound, gin.H{"error": fmt.Sprintf("update package not found: %v", err)})
return
}
// Validate all agents exist and are compatible
var results []map[string]interface{}
var errors []string
for _, agentID := range req.AgentIDs {
agent, err := h.agentQueries.GetAgentByID(agentID)
if err != nil {
errors = append(errors, fmt.Sprintf("Agent %s: not found", agentID))
continue
}
if agent.IsUpdating {
errors = append(errors, fmt.Sprintf("Agent %s: already updating", agentID))
continue
}
if !h.isPlatformCompatible(agent, req.Platform) {
errors = append(errors, fmt.Sprintf("Agent %s: platform incompatible", agentID))
continue
}
// Update agent status
if err := h.agentQueries.UpdateAgentUpdatingStatus(agentID, true, &req.Version); err != nil {
errors = append(errors, fmt.Sprintf("Agent %s: failed to update status", agentID))
continue
}
// Generate nonce for replay protection
nonceUUID := uuid.New()
nonceTimestamp := time.Now()
var nonceSignature string
if h.signingService != nil {
var err error
nonceSignature, err = h.signingService.SignNonce(nonceUUID, nonceTimestamp)
if err != nil {
errors = append(errors, fmt.Sprintf("Agent %s: failed to sign nonce", agentID))
h.agentQueries.UpdateAgentUpdatingStatus(agentID, false, nil)
continue
}
}
// Create update command
command := &models.AgentCommand{
ID: uuid.New(),
AgentID: agentID,
CommandType: "update_agent",
Params: map[string]interface{}{
"version": req.Version,
"platform": req.Platform,
"download_url": fmt.Sprintf("/api/v1/downloads/updates/%s", pkg.ID),
"signature": pkg.Signature,
"checksum": pkg.Checksum,
"file_size": pkg.FileSize,
"nonce_uuid": nonceUUID.String(),
"nonce_timestamp": nonceTimestamp.Format(time.RFC3339),
"nonce_signature": nonceSignature,
},
Status: models.CommandStatusPending,
Source: "web_ui_bulk",
CreatedAt: time.Now(),
}
if req.Scheduled != nil {
command.Params["scheduled_at"] = *req.Scheduled
}
if err := h.commandQueries.CreateCommand(command); err != nil {
// Rollback status
h.agentQueries.UpdateAgentUpdatingStatus(agentID, false, nil)
errors = append(errors, fmt.Sprintf("Agent %s: failed to create command", agentID))
continue
}
results = append(results, map[string]interface{}{
"agent_id": agentID,
"hostname": agent.Hostname,
"update_id": command.ID.String(),
"status": "initiated",
})
log.Printf("✅ Bulk update initiated for %s: %s (%s)", agent.Hostname, req.Version, req.Platform)
}
response := gin.H{
"message": fmt.Sprintf("Bulk update completed with %d successes and %d failures", len(results), len(errors)),
"updated": results,
"failed": errors,
"total_agents": len(req.AgentIDs),
"package_info": gin.H{
"version": pkg.Version,
"platform": pkg.Platform,
"file_size": pkg.FileSize,
"checksum": pkg.Checksum,
},
}
c.JSON(http.StatusOK, response)
}
// ListUpdatePackages handles GET /api/v1/updates/packages (list available update packages)
func (h *AgentUpdateHandler) ListUpdatePackages(c *gin.Context) {
version := c.Query("version")
platform := c.Query("platform")
limitStr := c.Query("limit")
offsetStr := c.Query("offset")
limit := 0
if limitStr != "" {
if l, err := strconv.Atoi(limitStr); err == nil && l > 0 {
limit = l
}
}
offset := 0
if offsetStr != "" {
if o, err := strconv.Atoi(offsetStr); err == nil && o >= 0 {
offset = o
}
}
packages, err := h.agentUpdateQueries.ListUpdatePackages(version, platform, limit, offset)
if err != nil {
c.JSON(http.StatusInternalServerError, gin.H{"error": "failed to list update packages"})
return
}
c.JSON(http.StatusOK, gin.H{
"packages": packages,
"total": len(packages),
"limit": limit,
"offset": offset,
})
}
// SignUpdatePackage handles POST /api/v1/updates/packages/sign (sign a new update package)
func (h *AgentUpdateHandler) SignUpdatePackage(c *gin.Context) {
var req struct {
Version string `json:"version" binding:"required"`
Platform string `json:"platform" binding:"required"`
Architecture string `json:"architecture" binding:"required"`
BinaryPath string `json:"binary_path" binding:"required"`
}
if err := c.ShouldBindJSON(&req); err != nil {
c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
return
}
if h.signingService == nil {
c.JSON(http.StatusServiceUnavailable, gin.H{"error": "signing service not available"})
return
}
// Sign the binary
pkg, err := h.signingService.SignFile(req.BinaryPath)
if err != nil {
c.JSON(http.StatusInternalServerError, gin.H{"error": fmt.Sprintf("failed to sign binary: %v", err)})
return
}
// Set additional fields
pkg.Version = req.Version
pkg.Platform = req.Platform
pkg.Architecture = req.Architecture
// Save to database
if err := h.agentUpdateQueries.CreateUpdatePackage(pkg); err != nil {
c.JSON(http.StatusInternalServerError, gin.H{"error": fmt.Sprintf("failed to save update package: %v", err)})
return
}
log.Printf("✅ Update package signed and saved: %s %s/%s (ID: %s)",
pkg.Version, pkg.Platform, pkg.Architecture, pkg.ID)
c.JSON(http.StatusOK, gin.H{
"message": "Update package signed successfully",
"package": pkg,
})
}
// isPlatformCompatible checks if the update package is compatible with the agent
func (h *AgentUpdateHandler) isPlatformCompatible(agent *models.Agent, updatePlatform string) bool {
// Normalize platform strings
agentPlatform := strings.ToLower(agent.OSType)
updatePlatform = strings.ToLower(updatePlatform)
// Check for basic OS compatibility
if !strings.Contains(updatePlatform, agentPlatform) {
return false
}
// Check architecture compatibility if specified
if strings.Contains(updatePlatform, "amd64") && !strings.Contains(strings.ToLower(agent.OSArchitecture), "amd64") {
return false
}
if strings.Contains(updatePlatform, "arm64") && !strings.Contains(strings.ToLower(agent.OSArchitecture), "arm64") {
return false
}
if strings.Contains(updatePlatform, "386") && !strings.Contains(strings.ToLower(agent.OSArchitecture), "386") {
return false
}
return true
}
// estimateUpdateTime estimates how long an update will take based on file size
func (h *AgentUpdateHandler) estimateUpdateTime(fileSize int64) int {
// Rough estimate: 1 second per MB + 30 seconds base time
seconds := int(fileSize/1024/1024) + 30
// Cap at 5 minutes
if seconds > 300 {
seconds = 300
}
return seconds
}
// GenerateUpdateNonce handles POST /api/v1/agents/:id/update-nonce
func (h *AgentUpdateHandler) GenerateUpdateNonce(c *gin.Context) {
agentID := c.Param("id")
targetVersion := c.Query("target_version")
if targetVersion == "" {
c.JSON(http.StatusBadRequest, gin.H{"error": "target_version query parameter required"})
return
}
if h.nonceService == nil {
c.JSON(http.StatusServiceUnavailable, gin.H{"error": "nonce service not available"})
return
}
// Parse agent ID as UUID
agentIDUUID, err := uuid.Parse(agentID)
if err != nil {
c.JSON(http.StatusBadRequest, gin.H{"error": "invalid agent ID format"})
return
}
// Verify agent exists
agent, err := h.agentQueries.GetAgentByID(agentIDUUID)
if err != nil {
c.JSON(http.StatusNotFound, gin.H{"error": "agent not found"})
return
}
// Generate nonce
nonce, err := h.nonceService.Generate(agentID, targetVersion)
if err != nil {
log.Printf("[ERROR] Failed to generate update nonce for agent %s: %v", agentID, err)
c.JSON(http.StatusInternalServerError, gin.H{"error": "failed to generate nonce"})
return
}
log.Printf("[system] Generated update nonce for agent %s (%s) -> %s", agentID, agent.Hostname, targetVersion)
c.JSON(http.StatusOK, gin.H{
"agent_id": agentID,
"hostname": agent.Hostname,
"current_version": agent.CurrentVersion,
"target_version": targetVersion,
"update_nonce": nonce,
"expires_at": time.Now().Add(10 * time.Minute).Unix(),
"expires_in_seconds": 600,
})
}
// CheckForUpdateAvailable handles GET /api/v1/agents/:id/updates/available
func (h *AgentUpdateHandler) CheckForUpdateAvailable(c *gin.Context) {
agentID := c.Param("id")
// Parse agent ID
agentIDUUID, err := uuid.Parse(agentID)
if err != nil {
c.JSON(http.StatusBadRequest, gin.H{"error": "invalid agent ID format"})
return
}
// Query database for agent's current version
agent, err := h.agentQueries.GetAgentByID(agentIDUUID)
if err != nil {
c.JSON(http.StatusNotFound, gin.H{"error": "agent not found"})
return
}
// Platform format: separate os_type and os_architecture from agent data
osType := strings.ToLower(agent.OSType)
osArch := agent.OSArchitecture
// Check if newer version available from agent_update_packages table
latestVersion, err := h.agentUpdateQueries.GetLatestVersionByTypeAndArch(osType, osArch)
if err != nil {
log.Printf("[DEBUG] GetLatestVersionByTypeAndArch error for %s/%s: %v", osType, osArch, err)
c.JSON(http.StatusOK, gin.H{
"hasUpdate": false,
"reason": "no packages available",
"currentVersion": agent.CurrentVersion,
})
return
}
// Check if this is actually newer than current version
hasUpdate := isVersionUpgrade(latestVersion, agent.CurrentVersion)
log.Printf("[DEBUG] Version comparison - latest: %s, current: %s, hasUpdate: %v for platform: %s/%s", latestVersion, agent.CurrentVersion, hasUpdate, osType, osArch)
// Special handling for sub-versions (0.1.23.5 vs 0.1.23)
if !hasUpdate && strings.HasPrefix(latestVersion, agent.CurrentVersion + ".") {
hasUpdate = true
log.Printf("[DEBUG] Detected sub-version upgrade: %s -> %s", agent.CurrentVersion, latestVersion)
}
c.JSON(http.StatusOK, gin.H{
"hasUpdate": hasUpdate,
"currentVersion": agent.CurrentVersion,
"latestVersion": latestVersion,
"platform": osType + "-" + osArch,
})
}
// GetUpdateStatus handles GET /api/v1/agents/:id/updates/status
func (h *AgentUpdateHandler) GetUpdateStatus(c *gin.Context) {
agentID := c.Param("id")
// Parse agent ID
agentIDUUID, err := uuid.Parse(agentID)
if err != nil {
c.JSON(http.StatusBadRequest, gin.H{"error": "invalid agent ID format"})
return
}
// Fetch agent with update state
agent, err := h.agentQueries.GetAgentByID(agentIDUUID)
if err != nil {
c.JSON(http.StatusNotFound, gin.H{"error": "agent not found"})
return
}
// Determine status from agent state + recent commands
var status string
var progress *int
var errorMsg *string
if agent.IsUpdating {
// Check if agent has pending update command
cmd, err := h.agentUpdateQueries.GetPendingUpdateCommand(agentID)
if err == nil && cmd != nil {
status = "downloading"
// Progress could be based on last acknowledgment time
if time.Since(cmd.CreatedAt) > 2*time.Minute {
status = "installing"
}
} else {
status = "pending"
}
} else {
status = "idle"
}
c.JSON(http.StatusOK, gin.H{
"status": status,
"progress": progress,
"error": errorMsg,
})
}
// isVersionUpgrade returns true if new version is greater than current version
func isVersionUpgrade(newVersion string, currentVersion string) bool {
// Parse semantic versions
newParts := strings.Split(newVersion, ".")
curParts := strings.Split(currentVersion, ".")
// Pad arrays to 3 parts
for len(newParts) < 3 {
newParts = append(newParts, "0")
}
for len(curParts) < 3 {
curParts = append(curParts, "0")
}
// Convert to integers for comparison
newMajor, _ := strconv.Atoi(newParts[0])
newMinor, _ := strconv.Atoi(newParts[1])
newPatch, _ := strconv.Atoi(newParts[2])
curMajor, _ := strconv.Atoi(curParts[0])
curMinor, _ := strconv.Atoi(curParts[1])
curPatch, _ := strconv.Atoi(curParts[2])
// Check if new > current (not equal, not less)
if newMajor > curMajor {
return true
}
if newMajor == curMajor && newMinor > curMinor {
return true
}
if newMajor == curMajor && newMinor == curMinor && newPatch > curPatch {
return true
}
return false
}