BREAKING CHANGE: Storage and system scans no longer create entries in update_logs **Problem** - Storage scans were appearing on Updates page (mixed with package updates) - System scans were appearing on Updates page (mixed with package updates) - Duplicate "Scan All" entries from collective + individual logging **Root Cause** Scan handlers were calling both ReportLog() and dedicated endpoints: - reportLogWithAck → POST /api/v1/agents/:id/logs → update_logs table - This caused storage/system metrics to appear alongside package updates **Fix** Removed ALL ReportLog() calls from scan handlers: 1. handleScanUpdatesV2 (lines 44-46): Removed collective logging 2. handleScanStorage (lines 103-105): Use only ReportStorageMetrics 3. handleScanSystem (lines 189-191): Use only ReportMetrics 4. handleScanDocker (lines 269-271): Use only ReportDockerImages **Verification** - All 4 handlers have working dedicated endpoints (verified via subagent) - Routes already registered: POST /storage-metrics, POST /metrics, etc. - Frontend queries correct endpoints (verified) - No data loss: dedicated endpoints store in proper tables **Result** - Storage scans → storage_metrics table → Storage page only ✅ - System scans → system reporting → System page only ✅ - Package updates → update_logs table → Updates page only ✅ - No duplicate "Scan All" entries ✅ **Files Changed** - aggregator-agent/cmd/agent/subsystem_handlers.go: Removed 20 lines of ReportLog calls - internal/api/handlers/agents.go: Command recovery enhancements - internal/api/handlers/updates.go: Subsystem extraction logic - internal/database/queries/commands.go: GetStuckCommands query
105 lines
2.6 KiB
Go
105 lines
2.6 KiB
Go
// Package constants provides centralized path definitions for the RedFlag agent.
|
|
// This package ensures consistency across all components and makes path management
|
|
// maintainable and testable.
|
|
package constants
|
|
|
|
import (
|
|
"path/filepath"
|
|
"runtime"
|
|
)
|
|
|
|
// Base directories
|
|
const (
|
|
LinuxBaseDir = "/var/lib/redflag"
|
|
WindowsBaseDir = "C:\\ProgramData\\RedFlag"
|
|
)
|
|
|
|
// Subdirectory structure
|
|
const (
|
|
AgentDir = "agent"
|
|
ServerDir = "server"
|
|
CacheSubdir = "cache"
|
|
StateSubdir = "state"
|
|
MigrationSubdir = "migration_backups"
|
|
)
|
|
|
|
// Config paths
|
|
const (
|
|
LinuxConfigBase = "/etc/redflag"
|
|
WindowsConfigBase = "C:\\ProgramData\\RedFlag"
|
|
ConfigFile = "config.json"
|
|
)
|
|
|
|
// Log paths
|
|
const (
|
|
LinuxLogBase = "/var/log/redflag"
|
|
)
|
|
|
|
// Legacy paths for migration
|
|
const (
|
|
LegacyConfigPath = "/etc/aggregator/config.json"
|
|
LegacyStatePath = "/var/lib/aggregator"
|
|
)
|
|
|
|
// GetBaseDir returns platform-specific base directory
|
|
func GetBaseDir() string {
|
|
if runtime.GOOS == "windows" {
|
|
return WindowsBaseDir
|
|
}
|
|
return LinuxBaseDir
|
|
}
|
|
|
|
// GetAgentStateDir returns /var/lib/redflag/agent/state
|
|
func GetAgentStateDir() string {
|
|
return filepath.Join(GetBaseDir(), AgentDir, StateSubdir)
|
|
}
|
|
|
|
// GetAgentCacheDir returns /var/lib/redflag/agent/cache
|
|
func GetAgentCacheDir() string {
|
|
return filepath.Join(GetBaseDir(), AgentDir, CacheSubdir)
|
|
}
|
|
|
|
// GetMigrationBackupDir returns /var/lib/redflag/agent/migration_backups
|
|
func GetMigrationBackupDir() string {
|
|
return filepath.Join(GetBaseDir(), AgentDir, MigrationSubdir)
|
|
}
|
|
|
|
// GetAgentConfigPath returns /etc/redflag/agent/config.json
|
|
func GetAgentConfigPath() string {
|
|
if runtime.GOOS == "windows" {
|
|
return filepath.Join(WindowsConfigBase, AgentDir, ConfigFile)
|
|
}
|
|
return filepath.Join(LinuxConfigBase, AgentDir, ConfigFile)
|
|
}
|
|
|
|
// GetAgentConfigDir returns /etc/redflag/agent
|
|
func GetAgentConfigDir() string {
|
|
if runtime.GOOS == "windows" {
|
|
return filepath.Join(WindowsConfigBase, AgentDir)
|
|
}
|
|
return filepath.Join(LinuxConfigBase, AgentDir)
|
|
}
|
|
|
|
// GetServerPublicKeyPath returns /etc/redflag/server/server_public_key
|
|
func GetServerPublicKeyPath() string {
|
|
if runtime.GOOS == "windows" {
|
|
return filepath.Join(WindowsConfigBase, ServerDir, "server_public_key")
|
|
}
|
|
return filepath.Join(LinuxConfigBase, ServerDir, "server_public_key")
|
|
}
|
|
|
|
// GetAgentLogDir returns /var/log/redflag/agent
|
|
func GetAgentLogDir() string {
|
|
return filepath.Join(LinuxLogBase, AgentDir)
|
|
}
|
|
|
|
// GetLegacyAgentConfigPath returns legacy /etc/aggregator/config.json
|
|
func GetLegacyAgentConfigPath() string {
|
|
return LegacyConfigPath
|
|
}
|
|
|
|
// GetLegacyAgentStatePath returns legacy /var/lib/aggregator
|
|
func GetLegacyAgentStatePath() string {
|
|
return LegacyStatePath
|
|
}
|