jpetree331
ec0d880036
- Fix migration 024 self-insert and bad column reference (F-B1-1, F-B1-2) Uses existing enabled/auto_run columns instead of non-existent deprecated - Abort server on migration failure instead of warning (F-B1-11) main.go now calls log.Fatalf, prints [INFO] only on success - Fix migration 018 scanner_config filename suffix (F-B1-3) Renumbered to 027 with .up.sql suffix - Remove GRANT to non-existent role in scanner_config (F-B1-4) - Resolve duplicate migration numbers 009 and 012 (F-B1-13) Renamed to 009b and 012b for unique lexical sorting - Add IF NOT EXISTS to all non-idempotent migrations (F-B1-15) Fixed: 011, 012, 017, 023, 023a - Replace N+1 dashboard stats loop with GetAllUpdateStats (F-B1-6) Single aggregate query replaces per-agent loop - Add composite index on agent_commands(status, sent_at) (F-B1-5) New migration 028 with partial index for timeout service - Add background refresh token cleanup goroutine (F-B1-10) 24-hour ticker calls CleanupExpiredTokens - ETHOS log format in migration runner (no emojis) All 55 tests pass (41 server + 14 agent). No regressions. See docs/B1_Fix_Implementation.md and DEV-025 through DEV-028. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
79 lines
2.0 KiB
Go
79 lines
2.0 KiB
Go
package migrations_test
|
|
|
|
// index_audit_test.go — Tests for missing database indexes.
|
|
//
|
|
// F-B1-5 FIXED: Migration 028 adds composite index on
|
|
// agent_commands(status, sent_at) for GetStuckCommands.
|
|
|
|
import (
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestStuckCommandsIndexIsMissing(t *testing.T) {
|
|
// POST-FIX: index on agent_commands(status, sent_at) must exist
|
|
files, err := os.ReadDir(".")
|
|
if err != nil {
|
|
t.Fatalf("failed to read migrations directory: %v", err)
|
|
}
|
|
|
|
foundIndex := false
|
|
for _, f := range files {
|
|
if !strings.HasSuffix(f.Name(), ".up.sql") {
|
|
continue
|
|
}
|
|
content, err := os.ReadFile(f.Name())
|
|
if err != nil {
|
|
continue
|
|
}
|
|
stmts := strings.Split(string(content), ";")
|
|
for _, stmt := range stmts {
|
|
lower := strings.ToLower(stmt)
|
|
if strings.Contains(lower, "create index") &&
|
|
strings.Contains(lower, "agent_commands") &&
|
|
strings.Contains(lower, "sent_at") {
|
|
foundIndex = true
|
|
}
|
|
}
|
|
}
|
|
|
|
if !foundIndex {
|
|
t.Error("[ERROR] [server] [database] F-B1-5 NOT FIXED: no index on agent_commands(status, sent_at)")
|
|
}
|
|
t.Log("[INFO] [server] [database] F-B1-5 FIXED: stuck commands index exists")
|
|
}
|
|
|
|
func TestStuckCommandsIndexExists(t *testing.T) {
|
|
files, err := os.ReadDir(".")
|
|
if err != nil {
|
|
t.Fatalf("failed to read migrations directory: %v", err)
|
|
}
|
|
|
|
foundIndex := false
|
|
for _, f := range files {
|
|
if !strings.HasSuffix(f.Name(), ".up.sql") {
|
|
continue
|
|
}
|
|
content, err := os.ReadFile(f.Name())
|
|
if err != nil {
|
|
continue
|
|
}
|
|
stmts := strings.Split(string(content), ";")
|
|
for _, stmt := range stmts {
|
|
lower := strings.ToLower(stmt)
|
|
if strings.Contains(lower, "create index") &&
|
|
strings.Contains(lower, "agent_commands") &&
|
|
strings.Contains(lower, "sent_at") {
|
|
foundIndex = true
|
|
}
|
|
}
|
|
}
|
|
|
|
if !foundIndex {
|
|
t.Errorf("[ERROR] [server] [database] no index on agent_commands covering sent_at.\n" +
|
|
"F-B1-5: GetStuckCommands needs index on (status, sent_at).")
|
|
}
|
|
t.Log("[INFO] [server] [database] F-B1-5 FIXED: stuck commands index exists")
|
|
}
|