Files
Redflag/aggregator-agent/internal/crypto/pubkey_test.go
jpetree331 f97d4845af feat(security): A-1 Ed25519 key rotation + A-2 replay attack fixes
Complete RedFlag codebase with two major security audit implementations.

== A-1: Ed25519 Key Rotation Support ==

Server:
- SignCommand sets SignedAt timestamp and KeyID on every signature
- signing_keys database table (migration 020) for multi-key rotation
- InitializePrimaryKey registers active key at startup
- /api/v1/public-keys endpoint for rotation-aware agents
- SigningKeyQueries for key lifecycle management

Agent:
- Key-ID-aware verification via CheckKeyRotation
- FetchAndCacheAllActiveKeys for rotation pre-caching
- Cache metadata with TTL and staleness fallback
- SecurityLogger events for key rotation and command signing

== A-2: Replay Attack Fixes (F-1 through F-7) ==

F-5 CRITICAL - RetryCommand now signs via signAndCreateCommand
F-1 HIGH     - v3 format: "{agent_id}:{cmd_id}:{type}:{hash}:{ts}"
F-7 HIGH     - Migration 026: expires_at column with partial index
F-6 HIGH     - GetPendingCommands/GetStuckCommands filter by expires_at
F-2 HIGH     - Agent-side executedIDs dedup map with cleanup
F-4 HIGH     - commandMaxAge reduced from 24h to 4h
F-3 CRITICAL - Old-format commands rejected after 48h via CreatedAt

Verification fixes: migration idempotency (ETHOS #4), log format
compliance (ETHOS #1), stale comments updated.

All 24 tests passing. Docker --no-cache build verified.
See docs/ for full audit reports and deviation log (DEV-001 to DEV-019).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-28 21:25:47 -04:00

51 lines
1.2 KiB
Go

package crypto
import (
"testing"
"time"
)
func TestCacheMetadataIsExpired(t *testing.T) {
tests := []struct {
name string
meta CacheMetadata
expected bool
}{
{
name: "fresh_within_ttl",
meta: CacheMetadata{CachedAt: time.Now(), TTLHours: 24},
expected: false,
},
{
name: "expired_past_ttl",
meta: CacheMetadata{CachedAt: time.Now().Add(-25 * time.Hour), TTLHours: 24},
expected: true,
},
{
name: "zero_ttl_defaults_24h_fresh",
meta: CacheMetadata{CachedAt: time.Now(), TTLHours: 0},
expected: false,
},
{
name: "zero_ttl_defaults_24h_expired",
meta: CacheMetadata{CachedAt: time.Now().Add(-25 * time.Hour), TTLHours: 0},
expected: true,
},
{
name: "exactly_at_ttl_boundary",
meta: CacheMetadata{CachedAt: time.Now().Add(-24 * time.Hour), TTLHours: 24},
expected: true, // at exactly TTL, treat as expired
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got := tt.meta.IsExpired()
if got != tt.expected {
t.Errorf("IsExpired() = %v, want %v (cachedAt=%v, ttl=%dh)",
got, tt.expected, tt.meta.CachedAt, tt.meta.TTLHours)
}
})
}
}