jpetree331
f97d4845af
Complete RedFlag codebase with two major security audit implementations.
== A-1: Ed25519 Key Rotation Support ==
Server:
- SignCommand sets SignedAt timestamp and KeyID on every signature
- signing_keys database table (migration 020) for multi-key rotation
- InitializePrimaryKey registers active key at startup
- /api/v1/public-keys endpoint for rotation-aware agents
- SigningKeyQueries for key lifecycle management
Agent:
- Key-ID-aware verification via CheckKeyRotation
- FetchAndCacheAllActiveKeys for rotation pre-caching
- Cache metadata with TTL and staleness fallback
- SecurityLogger events for key rotation and command signing
== A-2: Replay Attack Fixes (F-1 through F-7) ==
F-5 CRITICAL - RetryCommand now signs via signAndCreateCommand
F-1 HIGH - v3 format: "{agent_id}:{cmd_id}:{type}:{hash}:{ts}"
F-7 HIGH - Migration 026: expires_at column with partial index
F-6 HIGH - GetPendingCommands/GetStuckCommands filter by expires_at
F-2 HIGH - Agent-side executedIDs dedup map with cleanup
F-4 HIGH - commandMaxAge reduced from 24h to 4h
F-3 CRITICAL - Old-format commands rejected after 48h via CreatedAt
Verification fixes: migration idempotency (ETHOS #4), log format
compliance (ETHOS #1), stale comments updated.
All 24 tests passing. Docker --no-cache build verified.
See docs/ for full audit reports and deviation log (DEV-001 to DEV-019).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
56 lines
1.8 KiB
Go
56 lines
1.8 KiB
Go
package validator
|
|
|
|
import (
|
|
"fmt"
|
|
)
|
|
|
|
// IntervalValidator provides bounds checking for agent and scanner intervals
|
|
type IntervalValidator struct {
|
|
minCheckInSeconds int // 60 seconds (1 minute)
|
|
maxCheckInSeconds int // 3600 seconds (1 hour)
|
|
minScannerMinutes int // 1 minute
|
|
maxScannerMinutes int // 1440 minutes (24 hours)
|
|
}
|
|
|
|
// NewIntervalValidator creates a validator with default bounds
|
|
func NewIntervalValidator() *IntervalValidator {
|
|
return &IntervalValidator{
|
|
minCheckInSeconds: 60, // 1 minute minimum
|
|
maxCheckInSeconds: 3600, // 1 hour maximum
|
|
minScannerMinutes: 1, // 1 minute minimum
|
|
maxScannerMinutes: 1440, // 24 hours maximum
|
|
}
|
|
}
|
|
|
|
// ValidateCheckInInterval checks if agent check-in interval is within bounds
|
|
func (v *IntervalValidator) ValidateCheckInInterval(seconds int) error {
|
|
if seconds < v.minCheckInSeconds {
|
|
return fmt.Errorf("check-in interval %d seconds below minimum %d seconds (1 minute)",
|
|
seconds, v.minCheckInSeconds)
|
|
}
|
|
if seconds > v.maxCheckInSeconds {
|
|
return fmt.Errorf("check-in interval %d seconds above maximum %d seconds (1 hour)",
|
|
seconds, v.maxCheckInSeconds)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// ValidateScannerInterval checks if scanner interval is within bounds
|
|
func (v *IntervalValidator) ValidateScannerInterval(minutes int) error {
|
|
if minutes < v.minScannerMinutes {
|
|
return fmt.Errorf("scanner interval %d minutes below minimum %d minutes",
|
|
minutes, v.minScannerMinutes)
|
|
}
|
|
if minutes > v.maxScannerMinutes {
|
|
return fmt.Errorf("scanner interval %d minutes above maximum %d minutes (24 hours)",
|
|
minutes, v.maxScannerMinutes)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// GetBounds returns the current validation bounds (for testing/monitoring)
|
|
func (v *IntervalValidator) GetBounds() (minCheckIn, maxCheckIn, minScanner, maxScanner int) {
|
|
return v.minCheckInSeconds, v.maxCheckInSeconds,
|
|
v.minScannerMinutes, v.maxScannerMinutes
|
|
}
|