Fimeg/letta-code
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: patch release event leaks (#463)

Browse Source 
Co-authored-by: Letta <noreply@letta.com>
This commit is contained in:
Charles Packer
2026-01-04 19:19:34 -08:00
committed by GitHub
parent 1894a290d4
commit 36dcb891b0
2 changed files with 13 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/cli/components/PasteAwareTextInput.tsx
View File

@@ -461,42 +461,21 @@ export function PasteAwareTextInput({
// in use-input.js, which parses it as return + shift/ctrl/meta flags.
// The useInput handler at line 186 then handles the newline insertion.
// Kitty keyboard protocol: Arrow keys
// Format: ESC[1;modifier:event_typeX where X is A/B/C/D for up/down/right/left
// Event types: 1=press, 2=repeat, 3=release
// Handle press AND repeat events, ignore release
{
// Match ESC[1;N:1X or ESC[1;N:2X (press or repeat)
// biome-ignore lint/suspicious/noControlCharactersInRegex: ESC sequence matching
const arrowMatch = sequence.match(/^\x1b\[1;\d+:[12]([ABCD])$/);
if (arrowMatch) {
// Emit standard arrow key sequence
internal_eventEmitter.emit("input", `\x1b[${arrowMatch[1]}`);
return;
}
// Ignore arrow key release events only
// biome-ignore lint/suspicious/noControlCharactersInRegex: ESC sequence matching
if (/^\x1b\[1;\d+:3[ABCD]$/.test(sequence)) {
return;
}
}
// Note: Arrow keys with modifiers are now handled natively by parseKeypress
// since we use kitty protocol flag 1 only (no event types).
// With flag 1, arrows come as ESC[1;modifierD which parseKeypress recognizes.
// Previously we handled ESC[1;modifier:eventD format (with flag 7) here.
// fn+Delete (forward delete): ESC[3~ - standard ANSI escape sequence
// Also handle kitty extended format: ESC[3;modifier:event_type~
// Event types: 1=press, 2=repeat, 3=release
// With kitty flag 1, modifiers come as ESC[3;modifier~ (no event type).
// Use caretOffsetRef which is updated synchronously via onCursorOffsetChange
// biome-ignore lint/suspicious/noControlCharactersInRegex: ESC sequence matching
if (sequence === "\x1b[3~" || /^\x1b\[3;\d+:[12]~$/.test(sequence)) {
if (sequence === "\x1b[3~" || /^\x1b\[3;\d+~$/.test(sequence)) {
// Set timestamp so ink-text-input skips its delete handling
globalThis.__lettaForwardDeleteTimestamp = Date.now();
forwardDeleteAtCursor(caretOffsetRef.current);
return;
}
// Ignore forward delete release events
// biome-ignore lint/suspicious/noControlCharactersInRegex: ESC sequence matching
if (/^\x1b\[3;\d+:3~$/.test(sequence)) {
return;
}
// Option+Delete sequences (check first as they're exact matches)
// - iTerm2/some terminals: ESC + DEL (\x1b\x7f)

11
src/cli/utils/kittyProtocolDetector.ts
View File

@@ -137,10 +137,13 @@ export function isKittyProtocolEnabled(): boolean {
function enableKittyKeyboardProtocol() {
try {
// Enable keyboard progressive enhancement flags.
// Use 7 (=1|2|4): DISAMBIGUATE_ESCAPE_CODES | REPORT_EVENT_TYPES | REPORT_ALTERNATE_KEYS
// This matches what crossterm-based TUIs (e.g., codex) request.
fs.writeSync(process.stdout.fd, "\x1b[>7u");
// Enable keyboard progressive enhancement with flag 1 (DISAMBIGUATE_ESCAPE_CODES) only.
// Previously used flag 7 (1|2|4) but flag 2 (REPORT_EVENT_TYPES) causes release events
// that leak into input when typing fast in iTerm2/Kitty/etc.
// Flag 4 (REPORT_ALTERNATE_KEYS) provides data we don't use.
// Gemini CLI uses flag 1 only - this is the proven approach.
// See: .notes/csi-u-release-events-fix.md for full analysis.
fs.writeSync(process.stdout.fd, "\x1b[>1u");
kittyEnabled = true;
} catch {
// Ignore errors