Fimeg/letta-code
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: clarify /clear command output message (#609)

Browse Source 
Co-authored-by: Letta <noreply@letta.com>
This commit is contained in:
Charles Packer
2026-01-20 19:52:38 -08:00
committed by GitHub
parent 8c3a0f5bf6
commit 3bf43d7eb9
4 changed files with 20 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/tests/approval-recovery.test.ts
View File

@@ -124,8 +124,8 @@ describe("extractApprovals", () => {
const result = extractApprovals(msg);
expect(result.pendingApprovals).toHaveLength(1);
expect(result.pendingApprovals[0]!.toolCallId).toBe("call-1");
expect(result.pendingApprovals[0]!.toolName).toBe("Bash");
expect(result.pendingApprovals[0]?.toolCallId).toBe("call-1");
expect(result.pendingApprovals[0]?.toolName).toBe("Bash");
expect(result.pendingApproval?.toolCallId).toBe("call-1");
});
@@ -153,12 +153,12 @@ describe("extractApprovals", () => {
const result = extractApprovals(msg);
expect(result.pendingApprovals).toHaveLength(3);
expect(result.pendingApprovals[0]!.toolCallId).toBe("call-1");
expect(result.pendingApprovals[0]!.toolName).toBe("Bash");
expect(result.pendingApprovals[1]!.toolCallId).toBe("call-2");
expect(result.pendingApprovals[1]!.toolName).toBe("web_search");
expect(result.pendingApprovals[2]!.toolCallId).toBe("call-3");
expect(result.pendingApprovals[2]!.toolName).toBe("Read");
expect(result.pendingApprovals[0]?.toolCallId).toBe("call-1");
expect(result.pendingApprovals[0]?.toolName).toBe("Bash");
expect(result.pendingApprovals[1]?.toolCallId).toBe("call-2");
expect(result.pendingApprovals[1]?.toolName).toBe("web_search");
expect(result.pendingApprovals[2]?.toolCallId).toBe("call-3");
expect(result.pendingApprovals[2]?.toolName).toBe("Read");
// pendingApproval is deprecated, should be first item
expect(result.pendingApproval?.toolCallId).toBe("call-1");
});
@@ -175,8 +175,8 @@ describe("extractApprovals", () => {
const result = extractApprovals(msg);
expect(result.pendingApprovals).toHaveLength(1);
expect(result.pendingApprovals[0]!.toolCallId).toBe("call-legacy");
expect(result.pendingApprovals[0]!.toolName).toBe("Write");
expect(result.pendingApprovals[0]?.toolCallId).toBe("call-legacy");
expect(result.pendingApprovals[0]?.toolName).toBe("Write");
});
test("prefers tool_calls array over deprecated tool_call", () => {
@@ -193,7 +193,7 @@ describe("extractApprovals", () => {
// Should use tool_calls, not tool_call
expect(result.pendingApprovals).toHaveLength(1);
expect(result.pendingApprovals[0]!.toolCallId).toBe("call-new");
expect(result.pendingApprovals[0]?.toolCallId).toBe("call-new");
});
test("filters out tool calls without tool_call_id", () => {
@@ -210,8 +210,8 @@ describe("extractApprovals", () => {
// Should only include entries with valid tool_call_id
expect(result.pendingApprovals).toHaveLength(2);
expect(result.pendingApprovals[0]!.toolCallId).toBe("call-valid");
expect(result.pendingApprovals[1]!.toolCallId).toBe("call-valid-2");
expect(result.pendingApprovals[0]?.toolCallId).toBe("call-valid");
expect(result.pendingApprovals[1]?.toolCallId).toBe("call-valid-2");
});
test("returns empty array when no tool calls present", () => {
@@ -231,9 +231,9 @@ describe("extractApprovals", () => {
const result = extractApprovals(msg);
expect(result.pendingApprovals).toHaveLength(1);
expect(result.pendingApprovals[0]!.toolCallId).toBe("call-minimal");
expect(result.pendingApprovals[0]!.toolName).toBe("");
expect(result.pendingApprovals[0]!.toolArgs).toBe("");
expect(result.pendingApprovals[0]?.toolCallId).toBe("call-minimal");
expect(result.pendingApprovals[0]?.toolName).toBe("");
expect(result.pendingApprovals[0]?.toolArgs).toBe("");
});
});

2
src/tests/lazy-approval-recovery.test.ts
View File

@@ -33,7 +33,7 @@ interface StreamMessage {
subtype?: string;
message_type?: string;
stop_reason?: string;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
// biome-ignore lint/suspicious/noExplicitAny: index signature for arbitrary JSON fields
[key: string]: any;
}