fix: add full Gemini toolset support for UI rendering and permissions (#273)
Co-authored-by: Letta <noreply@letta.com>
This commit is contained in:
@@ -252,14 +252,16 @@ const DynamicPreview: React.FC<DynamicPreviewProps> = ({
|
||||
);
|
||||
}
|
||||
|
||||
// File edit previews: write/edit/multi_edit/replace/write_file
|
||||
// File edit previews: write/edit/multi_edit/replace/write_file/write_file_gemini
|
||||
if (
|
||||
(t === "write" ||
|
||||
t === "edit" ||
|
||||
t === "multiedit" ||
|
||||
t === "replace" ||
|
||||
t === "write_file" ||
|
||||
t === "writefile") &&
|
||||
t === "writefile" ||
|
||||
t === "write_file_gemini" ||
|
||||
t === "writefilegemini") &&
|
||||
parsedArgs
|
||||
) {
|
||||
try {
|
||||
@@ -269,7 +271,11 @@ const DynamicPreview: React.FC<DynamicPreviewProps> = ({
|
||||
if (precomputedDiff) {
|
||||
return (
|
||||
<Box flexDirection="column" paddingLeft={2}>
|
||||
{t === "write" || t === "write_file" || t === "writefile" ? (
|
||||
{t === "write" ||
|
||||
t === "write_file" ||
|
||||
t === "writefile" ||
|
||||
t === "write_file_gemini" ||
|
||||
t === "writefilegemini" ? (
|
||||
<AdvancedDiffRenderer
|
||||
precomputed={precomputedDiff}
|
||||
kind="write"
|
||||
@@ -307,7 +313,13 @@ const DynamicPreview: React.FC<DynamicPreviewProps> = ({
|
||||
}
|
||||
|
||||
// Fallback to non-precomputed rendering
|
||||
if (t === "write" || t === "write_file" || t === "writefile") {
|
||||
if (
|
||||
t === "write" ||
|
||||
t === "write_file" ||
|
||||
t === "writefile" ||
|
||||
t === "write_file_gemini" ||
|
||||
t === "writefilegemini"
|
||||
) {
|
||||
return (
|
||||
<Box flexDirection="column" paddingLeft={2}>
|
||||
<AdvancedDiffRenderer
|
||||
@@ -362,7 +374,9 @@ const DynamicPreview: React.FC<DynamicPreviewProps> = ({
|
||||
t === "edit" ||
|
||||
t === "multiedit" ||
|
||||
t === "replace" ||
|
||||
t === "write_file"
|
||||
t === "write_file" ||
|
||||
t === "write_file_gemini" ||
|
||||
t === "writefilegemini"
|
||||
) {
|
||||
return (
|
||||
<Box flexDirection="column" paddingLeft={2}>
|
||||
@@ -531,7 +545,13 @@ export const ApprovalDialog = memo(function ApprovalDialog({
|
||||
if (!parsedArgs || !approvalRequest) return null;
|
||||
|
||||
const toolName = approvalRequest.toolName.toLowerCase();
|
||||
if (toolName === "write") {
|
||||
if (
|
||||
toolName === "write" ||
|
||||
toolName === "write_file" ||
|
||||
toolName === "writefile" ||
|
||||
toolName === "write_file_gemini" ||
|
||||
toolName === "writefilegemini"
|
||||
) {
|
||||
const result = computeAdvancedDiff({
|
||||
kind: "write",
|
||||
filePath: parsedArgs.file_path as string,
|
||||
@@ -673,14 +693,20 @@ function getHeaderLabel(toolName: string): string {
|
||||
if (t === "updateplan") return "Plan update";
|
||||
// Gemini toolset (snake_case)
|
||||
if (t === "run_shell_command") return "Shell command";
|
||||
if (t === "read_file_gemini") return "Read File";
|
||||
if (t === "list_directory") return "List Directory";
|
||||
if (t === "glob_gemini") return "Find Files";
|
||||
if (t === "search_file_content") return "Search in Files";
|
||||
if (t === "write_file_gemini") return "Write File";
|
||||
if (t === "write_todos") return "Update Todos";
|
||||
if (t === "read_many_files") return "Read Multiple Files";
|
||||
// Gemini toolset (PascalCase → lowercased)
|
||||
if (t === "runshellcommand") return "Shell command";
|
||||
if (t === "readfilegemini") return "Read File";
|
||||
if (t === "listdirectory") return "List Directory";
|
||||
if (t === "globgemini") return "Find Files";
|
||||
if (t === "searchfilecontent") return "Search in Files";
|
||||
if (t === "writefilegemini") return "Write File";
|
||||
if (t === "writetodos") return "Update Todos";
|
||||
if (t === "readmanyfiles") return "Read Multiple Files";
|
||||
// Shared/additional tools
|
||||
|
||||
@@ -135,6 +135,7 @@ export const ToolCallMessage = memo(({ line }: { line: ToolCallLine }) => {
|
||||
const parsedArgs = JSON.parse(line.argsText);
|
||||
if (parsedArgs.todos && Array.isArray(parsedArgs.todos)) {
|
||||
// Convert todos to safe format for TodoRenderer
|
||||
// Note: Anthropic/Codex use "content", Gemini uses "description"
|
||||
const safeTodos = parsedArgs.todos.map((t: unknown, i: number) => {
|
||||
const rec = isRecord(t) ? t : {};
|
||||
const status: "pending" | "in_progress" | "completed" =
|
||||
@@ -144,8 +145,13 @@ export const ToolCallMessage = memo(({ line }: { line: ToolCallLine }) => {
|
||||
? "in_progress"
|
||||
: "pending";
|
||||
const id = typeof rec.id === "string" ? rec.id : String(i);
|
||||
// Handle both "content" (Anthropic/Codex) and "description" (Gemini) fields
|
||||
const content =
|
||||
typeof rec.content === "string" ? rec.content : JSON.stringify(t);
|
||||
typeof rec.content === "string"
|
||||
? rec.content
|
||||
: typeof rec.description === "string"
|
||||
? rec.description
|
||||
: JSON.stringify(t);
|
||||
const priority: "high" | "medium" | "low" | undefined =
|
||||
rec.priority === "high"
|
||||
? "high"
|
||||
|
||||
@@ -42,15 +42,21 @@ export function getDisplayToolName(rawName: string): string {
|
||||
|
||||
// Gemini toolset (snake_case)
|
||||
if (rawName === "run_shell_command") return "Shell";
|
||||
if (rawName === "read_file_gemini") return "Read";
|
||||
if (rawName === "list_directory") return "LS";
|
||||
if (rawName === "glob_gemini") return "Glob";
|
||||
if (rawName === "search_file_content") return "Grep";
|
||||
if (rawName === "write_file_gemini") return "Write";
|
||||
if (rawName === "write_todos") return "TODO";
|
||||
if (rawName === "read_many_files") return "Read Multiple";
|
||||
|
||||
// Gemini toolset (PascalCase)
|
||||
if (rawName === "RunShellCommand") return "Shell";
|
||||
if (rawName === "ReadFileGemini") return "Read";
|
||||
if (rawName === "ListDirectory") return "LS";
|
||||
if (rawName === "GlobGemini") return "Glob";
|
||||
if (rawName === "SearchFileContent") return "Grep";
|
||||
if (rawName === "WriteFileGemini") return "Write";
|
||||
if (rawName === "WriteTodos") return "TODO";
|
||||
if (rawName === "ReadManyFiles") return "Read Multiple";
|
||||
|
||||
|
||||
Reference in New Issue
Block a user