Fimeg/letta-code
1
0
Fork 0
Code Issues 2 Pull Requests Actions 4 Packages Projects Releases Wiki Activity

fix: skip no-op preset refresh on resume to avoid slow agent recompile (#1110)

Browse Source 
Co-authored-by: Letta <noreply@letta.com>
This commit is contained in:
jnjpng
2026-02-23 13:38:17 -08:00
committed by GitHub
parent 61b586174c
commit caa109c10d
4 changed files with 93 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/tests/agent/model-preset-refresh.wiring.test.ts
View File

@@ -50,9 +50,9 @@ describe("model preset refresh wiring", () => {
expect(source).toContain(
"const presetRefresh = getModelPresetUpdateForAgent(agent)",
);
expect(source).toContain("resumeRefreshUpdateArgs");
expect(source).toContain("presetRefresh.updateArgs.max_output_tokens");
expect(source).toContain("presetRefresh.updateArgs.parallel_tool_calls");
// Field extraction + skip logic is handled by getResumeRefreshArgs helper
expect(source).toContain("getResumeRefreshArgs(presetRefresh.updateArgs");
expect(source).toContain("needsUpdate");
expect(source).toContain("await updateAgentLLMConfig(");
expect(source).toContain("presetRefresh.modelHandle");
expect(source).not.toContain(
@@ -69,13 +69,26 @@ describe("model preset refresh wiring", () => {
expect(source).toContain(
"const presetRefresh = getModelPresetUpdateForAgent(agent)",
);
expect(source).toContain("resumeRefreshUpdateArgs");
expect(source).toContain("presetRefresh.updateArgs.max_output_tokens");
expect(source).toContain("presetRefresh.updateArgs.parallel_tool_calls");
// Field extraction + skip logic is handled by getResumeRefreshArgs helper
expect(source).toContain("getResumeRefreshArgs(presetRefresh.updateArgs");
expect(source).toContain("needsUpdate");
expect(source).toContain("await updateAgentLLMConfig(");
expect(source).toContain("presetRefresh.modelHandle");
expect(source).not.toContain(
"await updateAgentLLMConfig(\n agent.id,\n presetRefresh.modelHandle,\n presetRefresh.updateArgs,",
);
});
test("getResumeRefreshArgs helper owns field extraction and comparison", () => {
const path = fileURLToPath(
new URL("../../agent/model.ts", import.meta.url),
);
const source = readFileSync(path, "utf-8");
expect(source).toContain("export function getResumeRefreshArgs(");
expect(source).toContain("RESUME_REFRESH_FIELDS");
expect(source).toContain('"max_output_tokens"');
expect(source).toContain('"parallel_tool_calls"');
expect(source).toContain("needsUpdate");
});
});