Fimeg/letta-code
1
0
Fork 0
Code Issues 2 Pull Requests Actions 4 Packages Projects Releases Wiki Activity

ci: add typechecking, fail fast in CI, and patch typechecking errors (#63)

Browse Source
This commit is contained in:
Charles Packer
2025-11-04 11:50:07 -08:00
committed by GitHub
parent 42eb671bf4
commit cf73f3a11f
27 changed files with 183 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/permissions/analyzer.ts
View File

@@ -161,7 +161,7 @@ function analyzeBashApproval(
_workingDir: string,
): ApprovalContext {
const parts = command.trim().split(/\s+/);
const baseCommand = parts[0];
const baseCommand = parts[0] || "";
const firstArg = parts[1] || "";
// Dangerous commands - no persistence
@@ -178,7 +178,7 @@ function analyzeBashApproval(
"killall",
];
if (dangerousCommands.includes(baseCommand)) {
if (baseCommand && dangerousCommands.includes(baseCommand)) {
return {
recommendedRule: "",
ruleDescription: "",
@@ -248,7 +248,7 @@ function analyzeBashApproval(
}
// Package manager commands
if (["npm", "bun", "yarn", "pnpm"].includes(baseCommand)) {
if (baseCommand && ["npm", "bun", "yarn", "pnpm"].includes(baseCommand)) {
const subcommand = firstArg;
const thirdPart = parts[2];
@@ -295,7 +295,7 @@ function analyzeBashApproval(
"tail",
];
if (safeCommands.includes(baseCommand)) {
if (baseCommand && safeCommands.includes(baseCommand)) {
return {
recommendedRule: `Bash(${baseCommand}:*)`,
ruleDescription: `'${baseCommand}' commands`,
@@ -318,7 +318,7 @@ function analyzeBashApproval(
for (const segment of segments) {
const segmentParts = segment.trim().split(/\s+/);
const segmentBase = segmentParts[0];
const segmentBase = segmentParts[0] || "";
const segmentArg = segmentParts[1] || "";
// Check if this segment is git command
@@ -350,7 +350,7 @@ function analyzeBashApproval(
}
// Check if this segment is npm/bun/yarn/pnpm
if (["npm", "bun", "yarn", "pnpm"].includes(segmentBase)) {
if (segmentBase && ["npm", "bun", "yarn", "pnpm"].includes(segmentBase)) {
const subcommand = segmentArg;
const thirdPart = segmentParts[2];

8
src/permissions/matcher.ts
View File

@@ -26,7 +26,7 @@ export function matchesFilePattern(
// Extract tool name and file path from query
// Format: "ToolName(filePath)"
const queryMatch = query.match(/^([^(]+)\((.+)\)$/);
if (!queryMatch) {
if (!queryMatch || !queryMatch[1] || !queryMatch[2]) {
return false;
}
const queryTool = queryMatch[1];
@@ -35,7 +35,7 @@ export function matchesFilePattern(
// Extract tool name and glob pattern from permission rule
// Format: "ToolName(pattern)"
const patternMatch = pattern.match(/^([^(]+)\((.+)\)$/);
if (!patternMatch) {
if (!patternMatch || !patternMatch[1] || !patternMatch[2]) {
return false;
}
const patternTool = patternMatch[1];
@@ -98,7 +98,7 @@ export function matchesBashPattern(query: string, pattern: string): boolean {
// Extract the command from query
// Format: "Bash(actual command)" or "Bash()"
const queryMatch = query.match(/^Bash\((.*)\)$/);
if (!queryMatch) {
if (!queryMatch || queryMatch[1] === undefined) {
return false;
}
const command = queryMatch[1];
@@ -106,7 +106,7 @@ export function matchesBashPattern(query: string, pattern: string): boolean {
// Extract the command pattern from permission rule
// Format: "Bash(command pattern)" or "Bash()"
const patternMatch = pattern.match(/^Bash\((.*)\)$/);
if (!patternMatch) {
if (!patternMatch || patternMatch[1] === undefined) {
return false;
}
const commandPattern = patternMatch[1];