From e3ad1a3cf697d869fe0ada91763564b0e2b4882f Mon Sep 17 00:00:00 2001 From: christinatong01 Date: Mon, 23 Mar 2026 17:31:32 -0700 Subject: [PATCH] Revert "fix: add view image to plan mode allow list" This reverts commit 12e61d5b18645c7252a2f206b409ef5913a21d9d. --- src/permissions/mode.ts | 3 --- src/tests/permissions-mode.test.ts | 20 -------------------- 2 files changed, 23 deletions(-) diff --git a/src/permissions/mode.ts b/src/permissions/mode.ts index 7093b45..2e9e5aa 100644 --- a/src/permissions/mode.ts +++ b/src/permissions/mode.ts @@ -300,9 +300,6 @@ class PermissionModeManager { "Grep", "NotebookRead", "TodoWrite", - // Media tools (read-only) - "ViewImage", - "view_image", // Plan mode tools (must allow exit!) "ExitPlanMode", "exit_plan_mode", diff --git a/src/tests/permissions-mode.test.ts b/src/tests/permissions-mode.test.ts index 3aad164..b31dbc0 100644 --- a/src/tests/permissions-mode.test.ts +++ b/src/tests/permissions-mode.test.ts @@ -233,26 +233,6 @@ test("plan mode - allows Read", () => { expect(result.matchedRule).toBe("plan mode"); }); -test("plan mode - allows ViewImage", () => { - permissionMode.setMode("plan"); - - const permissions: PermissionRules = { - allow: [], - deny: [], - ask: [], - }; - - const result = checkPermission( - "ViewImage", - { path: "/Users/test/image.png" }, - permissions, - "/Users/test/project", - ); - - expect(result.decision).toBe("allow"); - expect(result.matchedRule).toBe("plan mode"); -}); - test("plan mode - allows TaskOutput", () => { permissionMode.setMode("plan");