Fimeg/letta-code
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: make overflow tests cross-platform for Windows CI (#490)

Browse Source 
Co-authored-by: Letta <noreply@letta.com>
This commit is contained in:
Charles Packer
2026-01-07 16:47:02 -08:00
committed by GitHub
parent 808ed36212
commit ec2627d749
3 changed files with 83 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/tests/tools/overflow-integration.test.ts
View File

@@ -25,9 +25,9 @@ describe("overflow integration tests", () => {
// Set USER_CWD for the test
process.env.USER_CWD = testWorkingDir;
// Generate a large output (more than 30K characters)
// Generate a large output (more than 30K characters) using node (cross-platform)
const command =
'for i in {1..2000}; do echo "Line $i with some padding text to make it longer"; done';
"node -e \"for(let i=1;i<=2000;i++) console.log('Line '+i+' with some padding text to make it longer')\"";
const result = await bash({ command });
@@ -100,9 +100,9 @@ describe("overflow integration tests", () => {
test("shows beginning and end of output", async () => {
process.env.USER_CWD = testWorkingDir;
// Generate output with distinctive beginning and end
// Generate output with distinctive beginning and end using node (cross-platform)
const command =
'echo "START_MARKER"; for i in {1..1000}; do echo "Middle line $i"; done; echo "END_MARKER"';
"node -e \"console.log('START_MARKER'); for(let i=1;i<=1000;i++) console.log('Middle line '+i); console.log('END_MARKER')\"";
const result = await bash({ command });

9
src/tests/tools/overflow.test.ts
View File

@@ -60,9 +60,12 @@ describe("overflow utilities", () => {
test("sanitizes working directory path", () => {
const dir = getOverflowDirectory("/path/with spaces/and:colons");
expect(dir).not.toContain(" ");
expect(dir).not.toContain(":");
expect(dir).toContain("path_with_spaces_and_colons");
// The sanitized segment (derived from input path) should have no spaces/colons
// On Windows, the full path contains C:\ so we check the segment, not full path
const sanitizedSegment = "path_with_spaces_and_colons";
expect(dir).toContain(sanitizedSegment);
expect(sanitizedSegment).not.toContain(" ");
expect(sanitizedSegment).not.toContain(":");
});
});