72d43c8a43
Co-authored-by: RinZ27 <222222878+RinZ27@users.noreply.github.com> Co-authored-by: Letta <noreply@letta.com>
47 lines
1.8 KiB
TypeScript
47 lines
1.8 KiB
TypeScript
import { expect, test } from "bun:test";
|
|
import { homedir } from "node:os";
|
|
import { resolve } from "node:path";
|
|
import {
|
|
isMemoryDirCommand,
|
|
isReadOnlyShellCommand,
|
|
} from "../permissions/readOnlyShell";
|
|
|
|
test("FIX: isReadOnlyShellCommand should not auto-approve reading sensitive files", () => {
|
|
// These used to return true, now should return false
|
|
expect(isReadOnlyShellCommand("cat /etc/passwd")).toBe(false);
|
|
expect(isReadOnlyShellCommand("grep secret /etc/shadow")).toBe(false);
|
|
expect(isReadOnlyShellCommand("head -n 20 ../../../.ssh/id_rsa")).toBe(false);
|
|
expect(
|
|
isReadOnlyShellCommand("cat C:\\Windows\\System32\\drivers\\etc\\hosts"),
|
|
).toBe(false);
|
|
|
|
// Normal safe commands should still work
|
|
expect(isReadOnlyShellCommand("ls")).toBe(true);
|
|
expect(isReadOnlyShellCommand("cat README.md")).toBe(true);
|
|
|
|
// Ensure `cd` cannot be used to bypass path checks via later relative reads
|
|
expect(isReadOnlyShellCommand("cd / && cat etc/passwd")).toBe(false);
|
|
expect(isReadOnlyShellCommand("cd C:\\ && type Windows\\win.ini")).toBe(
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("FIX: isMemoryDirCommand should not allow command injection via cd bypass", () => {
|
|
const agentId = "agent123";
|
|
const home = homedir();
|
|
const memoryDir = resolve(home, ".letta", "agents", agentId, "memory");
|
|
|
|
// This command starts with cd to memory dir, then tries to delete root
|
|
const dangerousCommand = `cd ${memoryDir} && rm -rf /`;
|
|
const dangerousWindowsCommand = `cd ${memoryDir} && type C:\\Windows\\win.ini`;
|
|
|
|
expect(isMemoryDirCommand(dangerousCommand, agentId)).toBe(false);
|
|
expect(isMemoryDirCommand(dangerousWindowsCommand, agentId)).toBe(false);
|
|
|
|
// Safe commands in memory dir should still work
|
|
expect(isMemoryDirCommand(`cd ${memoryDir} && ls`, agentId)).toBe(true);
|
|
expect(isMemoryDirCommand(`cd ${memoryDir} && git status`, agentId)).toBe(
|
|
true,
|
|
);
|
|
});
|