From 59c2b19812029018c53f311b444e192e4a6e89ab Mon Sep 17 00:00:00 2001
From: jnjpng <jin@letta.com>
Date: Fri, 9 Jan 2026 15:57:10 -0800
Subject: [PATCH] fix: remove sync model validator for env var (#8518)

* base

* import
---
 letta/schemas/environment_variables.py | 48 +++++++++++++-------------
 1 file changed, 24 insertions(+), 24 deletions(-)

diff --git a/letta/schemas/environment_variables.py b/letta/schemas/environment_variables.py
index 5db1c28a..2666a089 100644
--- a/letta/schemas/environment_variables.py
+++ b/letta/schemas/environment_variables.py
@@ -28,30 +28,30 @@ class EnvironmentVariableBase(OrmMetadataBase):
     # This validator syncs `value` and `value_enc` for backward compatibility:
     # - If `value_enc` is set but `value` is empty -> populate `value` from decrypted `value_enc`
     # - If `value` is set but `value_enc` is empty -> populate `value_enc` from encrypted `value`
-    @model_validator(mode="after")
-    def sync_value_and_value_enc(self):
-        """Sync deprecated `value` field with `value_enc` for backward compatibility."""
-        if self.value_enc and not self.value:
-            # ERROR: This should not happen - all code paths should populate value via async decryption
-            # Log error with stack trace to identify the caller that bypassed async decryption
-            logger.warning(
-                f"Sync decryption fallback triggered for env var key={self.key}. "
-                f"This indicates a code path that bypassed async decryption. Stack trace:\n{''.join(traceback.format_stack())}"
-            )
-            # Decrypt value_enc -> value (for API responses)
-            plaintext = self.value_enc.get_plaintext()
-            if plaintext:
-                self.value = plaintext
-        elif self.value and not self.value_enc:
-            # WARNING: This triggers sync encryption - should use async encryption where possible
-            # Log warning with stack trace to identify the caller
-            logger.warning(
-                f"Sync encryption fallback triggered for env var key={self.key}. "
-                f"This indicates a code path that bypassed async encryption. Stack trace:\n{''.join(traceback.format_stack())}"
-            )
-            # Encrypt value -> value_enc (for backward compat when value is provided directly)
-            self.value_enc = Secret.from_plaintext(self.value)
-        return self
+    # @model_validator(mode="after")
+    # def sync_value_and_value_enc(self):
+    #     """Sync deprecated `value` field with `value_enc` for backward compatibility."""
+    #     if self.value_enc and not self.value:
+    #         # ERROR: This should not happen - all code paths should populate value via async decryption
+    #         # Log error with stack trace to identify the caller that bypassed async decryption
+    #         logger.warning(
+    #             f"Sync decryption fallback triggered for env var key={self.key}. "
+    #             f"This indicates a code path that bypassed async decryption. Stack trace:\n{''.join(traceback.format_stack())}"
+    #         )
+    #         # Decrypt value_enc -> value (for API responses)
+    #         plaintext = self.value_enc.get_plaintext()
+    #         if plaintext:
+    #             self.value = plaintext
+    #     elif self.value and not self.value_enc:
+    #         # WARNING: This triggers sync encryption - should use async encryption where possible
+    #         # Log warning with stack trace to identify the caller
+    #         logger.warning(
+    #             f"Sync encryption fallback triggered for env var key={self.key}. "
+    #             f"This indicates a code path that bypassed async encryption. Stack trace:\n{''.join(traceback.format_stack())}"
+    #         )
+    #         # Encrypt value -> value_enc (for backward compat when value is provided directly)
+    #         self.value_enc = Secret.from_plaintext(self.value)
+    #     return self
 
 
 class EnvironmentVariableCreateBase(LettaBase):