From a7dc0253510f4d610f3e625f4c717c6628789f23 Mon Sep 17 00:00:00 2001 From: cthomas Date: Wed, 2 Jul 2025 16:12:08 -0700 Subject: [PATCH] chore: replace ada-002 model default (#3140) --- examples/Building agents with Letta.ipynb | 2 +- examples/docs/node/example.ts | 4 ++-- .../notebooks/Agentic RAG with Letta.ipynb | 16 +++++++-------- letta/schemas/embedding_config.py | 4 ++-- test_agent_serialization.json | 2 +- .../embedding_model_configs/azure_embed.json | 8 ++++---- .../embedding_model_configs/openai_embed.json | 10 +++++----- tests/configs/openai.json | 20 +++++++++---------- tests/integration_test_sleeptime_agent.py | 2 +- 9 files changed, 34 insertions(+), 34 deletions(-) diff --git a/examples/Building agents with Letta.ipynb b/examples/Building agents with Letta.ipynb index abf054a5..48c80b23 100644 --- a/examples/Building agents with Letta.ipynb +++ b/examples/Building agents with Letta.ipynb @@ -93,7 +93,7 @@ " ),\n", " ]\n", " model=\"openai/gpt-4o-mini\",\n", - " embedding=\"openai/text-embedding-ada-002\",\n", + " embedding=\"openai/text-embedding-3-small\",\n", ")" ] }, diff --git a/examples/docs/node/example.ts b/examples/docs/node/example.ts index 75974d17..b627b628 100644 --- a/examples/docs/node/example.ts +++ b/examples/docs/node/example.ts @@ -27,7 +27,7 @@ const agent = await client.agents.create({ }, ], model: 'openai/gpt-4o-mini', - embedding: 'openai/text-embedding-ada-002', + embedding: 'openai/text-embedding-3-small', }); console.log('Created agent with name', agent.name); @@ -100,7 +100,7 @@ console.log( let agentCopy = await client.agents.create({ model: 'openai/gpt-4o-mini', - embedding: 'openai/text-embedding-ada-002', + embedding: 'openai/text-embedding-3-small', }); let block = await client.agents.blocks.retrieve(agent.id, 'human'); agentCopy = await client.agents.blocks.attach(agentCopy.id, block.id); diff --git a/examples/notebooks/Agentic RAG with Letta.ipynb b/examples/notebooks/Agentic RAG with Letta.ipynb index d356c537..a52516e5 100644 --- a/examples/notebooks/Agentic RAG with Letta.ipynb +++ b/examples/notebooks/Agentic RAG with Letta.ipynb @@ -106,7 +106,7 @@ }, { "cell_type": "code", - "execution_count": 72, + "execution_count": null, "id": "c6d823fc-3e6e-4d32-a5a6-4c42dca60d94", "metadata": {}, "outputs": [], @@ -119,7 +119,7 @@ " ),\n", " ],\n", " model=\"openai/gpt-4\",\n", - " embedding=\"openai/text-embedding-ada-002\",\n", + " embedding=\"openai/text-embedding-3-small\",\n", ")" ] }, @@ -274,7 +274,7 @@ }, { "cell_type": "code", - "execution_count": 75, + "execution_count": null, "id": "4807532e-7b13-4c77-ac6b-b89338aeb3c2", "metadata": {}, "outputs": [ @@ -305,7 +305,7 @@ " ],\n", " # set automatic defaults for LLM/embedding config\n", " model=\"openai/gpt-4\",\n", - " embedding=\"openai/text-embedding-ada-002\",\n", + " embedding=\"openai/text-embedding-3-small\",\n", ")\n", "normal_agent.tools" ] @@ -320,7 +320,7 @@ }, { "cell_type": "code", - "execution_count": 76, + "execution_count": null, "id": "f1bbe4c7-d570-49f1-8c57-b39550f3ba65", "metadata": {}, "outputs": [ @@ -345,7 +345,7 @@ " ],\n", " # set automatic defaults for LLM/embedding config\n", " model=\"openai/gpt-4\",\n", - " embedding=\"openai/text-embedding-ada-002\",\n", + " embedding=\"openai/text-embedding-3-small\",\n", " tools=['send_message'], \n", " include_base_tools=False\n", ")\n", @@ -402,7 +402,7 @@ }, { "cell_type": "code", - "execution_count": 79, + "execution_count": null, "id": "77b324e9-2350-456e-8db5-3ccc8cec367f", "metadata": {}, "outputs": [], @@ -422,7 +422,7 @@ " ),\n", " ],\n", " model=\"openai/gpt-4\",\n", - " embedding=\"openai/text-embedding-ada-002\"\n", + " embedding=\"openai/text-embedding-3-small\"\n", ")" ] }, diff --git a/letta/schemas/embedding_config.py b/letta/schemas/embedding_config.py index 93cb6579..38e6542d 100644 --- a/letta/schemas/embedding_config.py +++ b/letta/schemas/embedding_config.py @@ -56,7 +56,7 @@ class EmbeddingConfig(BaseModel): @classmethod def default_config(cls, model_name: Optional[str] = None, provider: Optional[str] = None): - if model_name == "text-embedding-ada-002" or (not model_name and provider == "openai"): + if model_name == "text-embedding-ada-002" and provider == "openai": return cls( embedding_model="text-embedding-ada-002", embedding_endpoint_type="openai", @@ -64,7 +64,7 @@ class EmbeddingConfig(BaseModel): embedding_dim=1536, embedding_chunk_size=300, ) - if model_name == "text-embedding-3-small" and provider == "openai": + if (model_name == "text-embedding-3-small" and provider == "openai") or (not model_name and provider == "openai"): return cls( embedding_model="text-embedding-3-small", embedding_endpoint_type="openai", diff --git a/test_agent_serialization.json b/test_agent_serialization.json index c59d5c1b..6efaab99 100644 --- a/test_agent_serialization.json +++ b/test_agent_serialization.json @@ -42,7 +42,7 @@ "embedding_config": { "embedding_endpoint_type": "openai", "embedding_endpoint": "https://api.openai.com/v1", - "embedding_model": "text-embedding-ada-002", + "embedding_model": "text-embedding-3-small", "embedding_dim": 1536, "embedding_chunk_size": 300, "handle": null, diff --git a/tests/configs/embedding_model_configs/azure_embed.json b/tests/configs/embedding_model_configs/azure_embed.json index 3edc8d5c..e8c3df43 100644 --- a/tests/configs/embedding_model_configs/azure_embed.json +++ b/tests/configs/embedding_model_configs/azure_embed.json @@ -1,6 +1,6 @@ { - "embedding_endpoint_type": "azure", - "embedding_model": "text-embedding-ada-002", - "embedding_dim": 768, - "embedding_chunk_size": 300 + "embedding_endpoint_type": "azure", + "embedding_model": "text-embedding-3-small", + "embedding_dim": 768, + "embedding_chunk_size": 300 } diff --git a/tests/configs/embedding_model_configs/openai_embed.json b/tests/configs/embedding_model_configs/openai_embed.json index 8791ad67..52d7b727 100644 --- a/tests/configs/embedding_model_configs/openai_embed.json +++ b/tests/configs/embedding_model_configs/openai_embed.json @@ -1,7 +1,7 @@ { - "embedding_endpoint_type": "openai", - "embedding_endpoint": "https://api.openai.com/v1", - "embedding_model": "text-embedding-ada-002", - "embedding_dim": 1536, - "embedding_chunk_size": 300 + "embedding_endpoint_type": "openai", + "embedding_endpoint": "https://api.openai.com/v1", + "embedding_model": "text-embedding-3-small", + "embedding_dim": 1536, + "embedding_chunk_size": 300 } diff --git a/tests/configs/openai.json b/tests/configs/openai.json index 82ed0d72..12844963 100644 --- a/tests/configs/openai.json +++ b/tests/configs/openai.json @@ -1,12 +1,12 @@ { - "context_window": 8192, - "model": "gpt-4", - "model_endpoint_type": "openai", - "model_endpoint": "https://api.openai.com/v1", - "model_wrapper": null, - "embedding_endpoint_type": "openai", - "embedding_endpoint": "https://api.openai.com/v1", - "embedding_model": "text-embedding-ada-002", - "embedding_dim": 1536, - "embedding_chunk_size": 300 + "context_window": 8192, + "model": "gpt-4", + "model_endpoint_type": "openai", + "model_endpoint": "https://api.openai.com/v1", + "model_wrapper": null, + "embedding_endpoint_type": "openai", + "embedding_endpoint": "https://api.openai.com/v1", + "embedding_model": "text-embedding-3-small", + "embedding_dim": 1536, + "embedding_chunk_size": 300 } diff --git a/tests/integration_test_sleeptime_agent.py b/tests/integration_test_sleeptime_agent.py index fee463d5..cb2a66cd 100644 --- a/tests/integration_test_sleeptime_agent.py +++ b/tests/integration_test_sleeptime_agent.py @@ -433,7 +433,7 @@ async def test_sleeptime_agent_new_block_attachment(server, actor): ), ], model="anthropic/claude-3-5-sonnet-20240620", - embedding="openai/text-embedding-ada-002", + embedding="openai/text-embedding-3-small", enable_sleeptime=True, ), actor=actor,