Fimeg/letta-server
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: check both unique constraints in provider model sync (#9193)

Browse Source 
The sync_provider_models_async function was only checking for existing
models by (handle, organization_id, model_type) before creating, but
the database has a second unique constraint on (name, provider_id,
model_type). This caused UniqueConstraintViolationError when a model
with the same name/provider already existed under a different handle.

🤖 Generated with [Letta Code](https://letta.com)

Co-authored-by: Letta <noreply@letta.com>
This commit is contained in:
Kian Jones
2026-01-29 17:03:43 -08:00
committed by Caren Thomas
parent 3b5251fbd6
commit b0f8e16ac0
1 changed files with 28 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
letta/services/provider_manager.py
View File

@@ -675,7 +675,7 @@ class ProviderManager:
for llm_config in llm_models: for llm_config in llm_models:
logger.info(f" Checking LLM model: {llm_config.handle} (name: {llm_config.model})") logger.info(f" Checking LLM model: {llm_config.handle} (name: {llm_config.model})")
# Check if model already exists (excluding soft-deleted ones) # Check if model already exists by handle (excluding soft-deleted ones)
existing = await ProviderModelORM.list_async( existing = await ProviderModelORM.list_async(
db_session=session, db_session=session,
limit=1, limit=1,
@@ -687,6 +687,19 @@ class ProviderManager:
}, },
) )
# Also check by name+provider_id (covers unique_model_per_provider_and_type constraint)
if not existing:
existing = await ProviderModelORM.list_async(
db_session=session,
limit=1,
check_is_deleted=True,
**{
"name": llm_config.model,
"provider_id": provider.id,
"model_type": "llm",
},
)
if not existing: if not existing:
logger.info(f" Creating new LLM model {llm_config.handle}") logger.info(f" Creating new LLM model {llm_config.handle}")
# Create new model entry # Create new model entry
@@ -754,7 +767,7 @@ class ProviderManager:
for embedding_config in embedding_models: for embedding_config in embedding_models:
logger.info(f" Checking embedding model: {embedding_config.handle} (name: {embedding_config.embedding_model})") logger.info(f" Checking embedding model: {embedding_config.handle} (name: {embedding_config.embedding_model})")
# Check if model already exists (excluding soft-deleted ones) # Check if model already exists by handle (excluding soft-deleted ones)
existing = await ProviderModelORM.list_async( existing = await ProviderModelORM.list_async(
db_session=session, db_session=session,
limit=1, limit=1,
@@ -766,6 +779,19 @@ class ProviderManager:
}, },
) )
# Also check by name+provider_id (covers unique_model_per_provider_and_type constraint)
if not existing:
existing = await ProviderModelORM.list_async(
db_session=session,
limit=1,
check_is_deleted=True,
**{
"name": embedding_config.embedding_model,
"provider_id": provider.id,
"model_type": "embedding",
},
)
if not existing: if not existing:
logger.info(f" Creating new embedding model {embedding_config.handle}") logger.info(f" Creating new embedding model {embedding_config.handle}")
# Create new model entry # Create new model entry