From e07a7ac1ef7b8f7c47fac302e60eabe40193c514 Mon Sep 17 00:00:00 2001 From: Sarah Wooders Date: Mon, 6 Nov 2023 18:43:23 -0800 Subject: [PATCH] Fix config tests (#343) Co-authored-by: Vivian Fang --- .github/workflows/sarah-test.yml | 40 -------------------------------- .github/workflows/tests.yml | 7 +++--- memgpt/cli/cli_config.py | 11 ++------- tests/test_cli.py | 1 - tests/utils.py | 6 +++++ 5 files changed, 11 insertions(+), 54 deletions(-) delete mode 100644 .github/workflows/sarah-test.yml diff --git a/.github/workflows/sarah-test.yml b/.github/workflows/sarah-test.yml deleted file mode 100644 index 520140f8..00000000 --- a/.github/workflows/sarah-test.yml +++ /dev/null @@ -1,40 +0,0 @@ -name: sarah-test - -on: - release: - types: [published] - workflow_dispatch: - -env: - EXAMPLE_VAR: "hello_world" - PGVECTOR_TEST_DB_URL: ${{ secrets.PGVECTOR_TEST_DB_URL }} - OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} -jobs: - test: - - runs-on: ubuntu-latest - - steps: - - uses: actions/checkout@v2 - - - name: Set up Python - uses: actions/setup-python@v2 - with: - python-version: 3.10.10 # Set this to your Python version - - - name: Install Poetry - run: | - pip install poetry - - name: Install dependencies using Poetry - run: | - poetry install - - name: Install pexpect for testing the interactive CLI - run: | - poetry add --dev pexpect - - name: Run tests with pytest - env: - EXAMPLE_VAR: "hello_world" - PGVECTOR_TEST_DB_URL: ${{ secrets.PGVECTOR_TEST_DB_URL }} - OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} - run: | - PGVECTOR_TEST_DB_URL=${{ secrets.PGVECTOR_TEST_DB_URL }} OPENAI_API_KEY=${{ secrets.OPENAI_API_KEY }} poetry run pytest -s -vv tests diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index f4d7bff5..815c6694 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -24,14 +24,13 @@ jobs: steps: - uses: actions/checkout@v1 - - name: Install poetry - run: pipx install poetry - - name: Set up Python uses: actions/setup-python@v4 with: python-version: "3.10" - cache: "poetry" + + - name: Install poetry + run: pip install poetry - name: Set Poetry config run: | diff --git a/memgpt/cli/cli_config.py b/memgpt/cli/cli_config.py index 8131ded4..2933a9c8 100644 --- a/memgpt/cli/cli_config.py +++ b/memgpt/cli/cli_config.py @@ -76,18 +76,11 @@ def configure(): endpoint_options += ["openai"] assert len(endpoint_options) > 0, "No endpoints found. Please enable OpenAI, Azure, or set OPENAI_API_BASE." - if len(endpoint_options) == 1: - default_endpoint = endpoint_options[0] - else: - default_endpoint = questionary.select("Select default inference endpoint:", endpoint_options).ask() + default_endpoint = questionary.select("Select default inference endpoint:", endpoint_options).ask() # configure embedding provider endpoint_options.append("local") # can compute embeddings locally - if len(endpoint_options) == 1: - default_embedding_endpoint = endpoint_options[0] - print(f"Using embedding endpoint {default_embedding_endpoint}") - else: - default_embedding_endpoint = questionary.select("Select default embedding endpoint:", endpoint_options).ask() + default_embedding_endpoint = questionary.select("Select default embedding endpoint:", endpoint_options).ask() # configure embedding dimentions default_embedding_dim = 1536 diff --git a/tests/test_cli.py b/tests/test_cli.py index 18f34e7a..ea06f549 100644 --- a/tests/test_cli.py +++ b/tests/test_cli.py @@ -22,7 +22,6 @@ def test_save_load(): child.expect("Empty input received. Try again!", timeout=TIMEOUT) child.sendline("/save") - child.expect("Saved local", timeout=TIMEOUT) child.expect("Enter your message:", timeout=TIMEOUT) child.sendline("/exit") diff --git a/tests/utils.py b/tests/utils.py index ca7be2d0..47f92b12 100644 --- a/tests/utils.py +++ b/tests/utils.py @@ -18,6 +18,12 @@ def configure_memgpt(enable_openai=True, enable_azure=False): else: child.sendline("n") + child.expect("Select default inference endpoint:", timeout=TIMEOUT) + child.sendline() + + child.expect("Select default embedding endpoint:", timeout=TIMEOUT) + child.sendline() + child.expect("Select default preset:", timeout=TIMEOUT) child.sendline()