feat: Parse out errors from venv local sandbox (#2166)

tests/integration_test_tool_execution_sandbox.py

@@ -183,6 +183,23 @@ def get_warning_tool(test_user):
     yield tool
 
 
+@pytest.fixture
+def always_err_tool(test_user):
+    def error() -> str:
+        """
+        Simple function that errors
+
+        Returns:
+            str: not important
+        """
+        # Raise a unusual error so we know it's from this function
+        raise ZeroDivisionError("This is an intentionally weird division!")
+
+    tool = create_tool_from_func(error)
+    tool = ToolManager().create_or_update_tool(tool, test_user)
+    yield tool
+
+
 @pytest.fixture
 def list_tool(test_user):
     def create_list():
@@ -244,6 +261,33 @@ def agent_state():
     yield agent_state
 
 
+@pytest.fixture
+def custom_test_sandbox_config(test_user):
+    """
+    Fixture to create a consistent local sandbox configuration for tests.
+
+    Args:
+        test_user: The test user to be used for creating the sandbox configuration.
+
+    Returns:
+        A tuple containing the SandboxConfigManager and the created sandbox configuration.
+    """
+    # Create the SandboxConfigManager
+    manager = SandboxConfigManager(tool_settings)
+
+    # Set the sandbox to be within the external codebase path and use a venv
+    external_codebase_path = str(Path(__file__).parent / "test_tool_sandbox" / "restaurant_management_system")
+    local_sandbox_config = LocalSandboxConfig(sandbox_dir=external_codebase_path, use_venv=True)
+
+    # Create the sandbox configuration
+    config_create = SandboxConfigCreate(config=local_sandbox_config.model_dump())
+
+    # Create or update the sandbox configuration
+    manager.create_or_update_sandbox_config(sandbox_config_create=config_create, actor=test_user)
+
+    return manager, local_sandbox_config
+
+
 # Local sandbox tests
 
 
@@ -347,16 +391,7 @@ def test_local_sandbox_e2e_composio_star_github(mock_e2b_api_key_none, check_com
 
 
 @pytest.mark.local_sandbox
-def test_local_sandbox_external_codebase(mock_e2b_api_key_none, external_codebase_tool, test_user):
-    # Make the external codebase the sandbox config
-    manager = SandboxConfigManager(tool_settings)
-
-    # Set the sandbox to be within the external codebase path and use a venv
-    external_codebase_path = str(Path(__file__).parent / "test_tool_sandbox" / "restaurant_management_system")
-    local_sandbox_config = LocalSandboxConfig(sandbox_dir=external_codebase_path, use_venv=True)
-    config_create = SandboxConfigCreate(config=local_sandbox_config.model_dump())
-    manager.create_or_update_sandbox_config(sandbox_config_create=config_create, actor=test_user)
-
+def test_local_sandbox_external_codebase(mock_e2b_api_key_none, custom_test_sandbox_config, external_codebase_tool, test_user):
     # Set the args
     args = {"percentage": 10}
 
@@ -370,21 +405,23 @@ def test_local_sandbox_external_codebase(mock_e2b_api_key_none, external_codebas
 
 
 @pytest.mark.local_sandbox
-def test_local_sandbox_with_venv_and_warnings_does_not_error(mock_e2b_api_key_none, get_warning_tool, test_user):
-    # Make the external codebase the sandbox config
-    manager = SandboxConfigManager(tool_settings)
-
-    # Set the sandbox to be within the external codebase path and use a venv
-    external_codebase_path = str(Path(__file__).parent / "test_tool_sandbox" / "restaurant_management_system")
-    local_sandbox_config = LocalSandboxConfig(sandbox_dir=external_codebase_path, use_venv=True)
-    config_create = SandboxConfigCreate(config=local_sandbox_config.model_dump())
-    manager.create_or_update_sandbox_config(sandbox_config_create=config_create, actor=test_user)
-
+def test_local_sandbox_with_venv_and_warnings_does_not_error(
+    mock_e2b_api_key_none, custom_test_sandbox_config, get_warning_tool, test_user
+):
     sandbox = ToolExecutionSandbox(get_warning_tool.name, {}, user_id=test_user.id)
     result = sandbox.run()
     assert result.func_return == "Hello World"
 
 
+@pytest.mark.e2b_sandbox
+def test_local_sandbox_with_venv_errors(mock_e2b_api_key_none, custom_test_sandbox_config, always_err_tool, test_user):
+    sandbox = ToolExecutionSandbox(always_err_tool.name, {}, user_id=test_user.id)
+
+    # run the sandbox
+    with pytest.raises(ZeroDivisionError, match="This is an intentionally weird division!"):
+        sandbox.run()
+
+
 # E2B sandbox tests