From ef9bac78ec1ee3b1ba824e43e2e29d923c6914b0 Mon Sep 17 00:00:00 2001 From: cthomas Date: Fri, 19 Sep 2025 14:04:28 -0700 Subject: [PATCH] chore: cleanup experimental flag (#4818) --- .github/workflows/core-unit-sqlite-test.yaml | 2 +- .github/workflows/core-unit-test.yml | 2 +- .github/workflows/model-sweep.yaml | 1 - letta/plugins/defaults.py | 8 ++++---- letta/settings.py | 1 - 5 files changed, 6 insertions(+), 8 deletions(-) diff --git a/.github/workflows/core-unit-sqlite-test.yaml b/.github/workflows/core-unit-sqlite-test.yaml index 34f5090c..105b24df 100644 --- a/.github/workflows/core-unit-sqlite-test.yaml +++ b/.github/workflows/core-unit-sqlite-test.yaml @@ -50,7 +50,7 @@ jobs: {"test_suite": "test_sources.py"}, {"test_suite": "test_managers.py"}, {"test_suite": "sdk/"}, - {"test_suite": "mcp_tests/", "use_experimental": true}, + {"test_suite": "mcp_tests/"}, {"test_suite": "test_timezone_formatting.py"}, {"test_suite": "test_plugins.py"}, {"test_suite": "test_embeddings.py"}, diff --git a/.github/workflows/core-unit-test.yml b/.github/workflows/core-unit-test.yml index 7a11eed0..15f58eda 100644 --- a/.github/workflows/core-unit-test.yml +++ b/.github/workflows/core-unit-test.yml @@ -51,7 +51,7 @@ jobs: {"test_suite": "test_providers.py"}, {"test_suite": "test_sources.py"}, {"test_suite": "sdk/"}, - {"test_suite": "mcp_tests/", "use_experimental": true}, + {"test_suite": "mcp_tests/"}, {"test_suite": "test_timezone_formatting.py"}, {"test_suite": "test_plugins.py"}, {"test_suite": "test_embeddings.py"}, diff --git a/.github/workflows/model-sweep.yaml b/.github/workflows/model-sweep.yaml index 5ce8b5eb..66f226d0 100644 --- a/.github/workflows/model-sweep.yaml +++ b/.github/workflows/model-sweep.yaml @@ -92,7 +92,6 @@ jobs: GOOGLE_CLOUD_PROJECT: ${{ secrets.GOOGLE_CLOUD_PROJECT}} GOOGLE_CLOUD_LOCATION: ${{ secrets.GOOGLE_CLOUD_LOCATION}} DEEPSEEK_API_KEY: ${{ env.DEEPSEEK_API_KEY}} - LETTA_USE_EXPERIMENTAL: 1 run: | uv run pytest \ -s -vv \ diff --git a/letta/plugins/defaults.py b/letta/plugins/defaults.py index b22e1064..f3032ad2 100644 --- a/letta/plugins/defaults.py +++ b/letta/plugins/defaults.py @@ -2,10 +2,10 @@ from letta.settings import settings def is_experimental_enabled(feature_name: str, **kwargs) -> bool: - if feature_name in ("async_agent_loop", "summarize"): - if not (kwargs.get("eligibility", False) and settings.use_experimental): - return False - return True + # if feature_name in ("async_agent_loop", "summarize"): + # if not (kwargs.get("eligibility", False) and settings.use_experimental): + # return False + # return True # Err on safety here, disabling experimental if not handled here. return False diff --git a/letta/settings.py b/letta/settings.py index 06de0cdd..6c4f3b70 100644 --- a/letta/settings.py +++ b/letta/settings.py @@ -276,7 +276,6 @@ class Settings(BaseSettings): event_loop_threadpool_max_workers: int = 43 # experimental toggle - use_experimental: bool = False use_vertex_structured_outputs_experimental: bool = False use_asyncio_shield: bool = True