From fa23566f245ffaf75828d12b95b8dae4c27e235f Mon Sep 17 00:00:00 2001
From: Andy Li <55300002+cliandy@users.noreply.github.com>
Date: Mon, 7 Jul 2025 12:37:39 -0700
Subject: [PATCH] chore: proper logging for sentry (#3195)

---
 letta/server/rest_api/app.py                        | 13 -------------
 .../file_processor/embedder/openai_embedder.py      |  2 +-
 letta/services/file_processor/file_processor.py     |  4 ++--
 3 files changed, 3 insertions(+), 16 deletions(-)

diff --git a/letta/server/rest_api/app.py b/letta/server/rest_api/app.py
index 203a5d6c..8ddb175f 100644
--- a/letta/server/rest_api/app.py
+++ b/letta/server/rest_api/app.py
@@ -160,18 +160,6 @@ async def lifespan(app_: FastAPI):
     logger.info(f"[Worker {worker_id}] Lifespan shutdown completed")
 
 
-# TODO: Make this more robust
-def filter_out_sentry_errors(event, hint):
-    if (
-        "File processing failed" in str(event.get("exception"))
-        or "Default chunking also failed for" in str(event.get("exception"))
-        or "Failed to embed batch of size 32" in str(event.get("exception"))
-        or "`inputs` must have less than 512 tokens" in str(event.get("exception"))
-    ):
-        return None
-    return event
-
-
 def create_application() -> "FastAPI":
     """the application start routine"""
     # global server
@@ -187,7 +175,6 @@ def create_application() -> "FastAPI":
             _experiments={
                 "continuous_profiling_auto_start": True,
             },
-            before_send=filter_out_sentry_errors,
         )
 
     debug_mode = "--debug" in sys.argv
diff --git a/letta/services/file_processor/embedder/openai_embedder.py b/letta/services/file_processor/embedder/openai_embedder.py
index ce43a72d..5a888549 100644
--- a/letta/services/file_processor/embedder/openai_embedder.py
+++ b/letta/services/file_processor/embedder/openai_embedder.py
@@ -91,7 +91,7 @@ class OpenAIEmbedder(BaseEmbedder):
             try:
                 return await self._embed_batch(batch, indices)
             except Exception as e:
-                logger.error(f"Failed to embed batch of size {len(batch)}: {str(e)}")
+                logger.error("Failed to embed batch of size %s: %s", len(batch), e)
                 log_event("embedder.batch_failed", {"batch_size": len(batch), "error": str(e), "error_type": type(e).__name__})
                 raise
 
diff --git a/letta/services/file_processor/file_processor.py b/letta/services/file_processor/file_processor.py
index 09cf8c0b..07b324c9 100644
--- a/letta/services/file_processor/file_processor.py
+++ b/letta/services/file_processor/file_processor.py
@@ -90,7 +90,7 @@ class FileProcessor:
                 return all_passages
 
             except Exception as fallback_error:
-                logger.error(f"Default chunking also failed for {filename}: {str(fallback_error)}")
+                logger.error("Default chunking also failed for %s: %s", filename, fallback_error)
                 log_event(
                     "file_processor.default_chunking_also_failed",
                     {"filename": filename, "fallback_error": str(fallback_error), "fallback_error_type": type(fallback_error).__name__},
@@ -200,7 +200,7 @@ class FileProcessor:
             return all_passages
 
         except Exception as e:
-            logger.error(f"File processing failed for {filename}: {str(e)}")
+            logger.error("File processing failed for %s: %s", filename, e)
             log_event(
                 "file_processor.processing_failed",
                 {