Fimeg/letta-code
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(permissions): prevent yolo mode desync in approval handling (#1021)

Browse Source
This commit is contained in:
paulbettner
2026-02-18 20:23:36 -05:00
committed by GitHub
parent 75b9615d47
commit 3871fa810c
1 changed files with 27 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/cli/App.tsx
View File

@@ -929,6 +929,11 @@ export default function App({
const [uiPermissionMode, setUiPermissionMode] = useState(
permissionMode.getMode(),
);
const uiPermissionModeRef = useRef(uiPermissionMode);
useEffect(() => {
uiPermissionModeRef.current = uiPermissionMode;
}, [uiPermissionMode]);
const statusLineTriggerVersionRef = useRef(0);
const [statusLineTriggerVersion, setStatusLineTriggerVersion] = useState(0);
@@ -3016,6 +3021,7 @@ export default function App({
setUiRalphActive(false);
if (wasYolo) {
permissionMode.setMode("default");
setUiPermissionMode("default");
}
// Add completion status to transcript
@@ -3040,6 +3046,7 @@ export default function App({
setUiRalphActive(false);
if (wasYolo) {
permissionMode.setMode("default");
setUiPermissionMode("default");
}
// Add status to transcript
@@ -3988,6 +3995,14 @@ export default function App({
}
// Check permissions for all approvals (including fancy UI tools)
// Ensure the singleton permission mode matches what the UI shows.
// This prevents rare races where the footer shows YOLO but approvals still
// get classified using the default mode.
const desiredMode = uiPermissionModeRef.current;
if (permissionMode.getMode() !== desiredMode) {
permissionMode.setMode(desiredMode);
}
const { needsUserInput, autoAllowed, autoDenied } =
await classifyApprovals(approvalsToProcess, {
getContext: analyzeToolApproval,
@@ -5599,6 +5614,11 @@ export default function App({
}
// There are pending approvals - check permissions (respects yolo mode)
const desiredMode = uiPermissionModeRef.current;
if (permissionMode.getMode() !== desiredMode) {
permissionMode.setMode(desiredMode);
}
const { needsUserInput, autoAllowed, autoDenied } =
await classifyApprovals(existingApprovals, {
getContext: analyzeToolApproval,
@@ -5921,6 +5941,7 @@ export default function App({
justActivatedRalph = true;
if (isYolo) {
permissionMode.setMode("bypassPermissions");
setUiPermissionMode("bypassPermissions");
}
const ralphState = ralphMode.getState();
@@ -6612,6 +6633,7 @@ export default function App({
setUiRalphActive(true);
if (isYolo) {
permissionMode.setMode("bypassPermissions");
setUiPermissionMode("bypassPermissions");
}
const ralphState = ralphMode.getState();
@@ -8547,6 +8569,11 @@ ${SYSTEM_REMINDER_CLOSE}
if (existingApprovals && existingApprovals.length > 0) {
// There are pending approvals - check permissions first (respects yolo mode)
const desiredMode = uiPermissionModeRef.current;
if (permissionMode.getMode() !== desiredMode) {
permissionMode.setMode(desiredMode);
}
const { needsUserInput, autoAllowed, autoDenied } =
await classifyApprovals(existingApprovals, {
getContext: analyzeToolApproval,