chore: remove system-append flag (#1280)

This commit is contained in:
Devansh Jain
2026-03-05 15:37:31 -08:00
committed by GitHub
parent 6540a38f82
commit 6a65ff5008
5 changed files with 16 additions and 12 deletions

View File

@@ -143,8 +143,6 @@ export interface CreateAgentOptions {
systemPromptPreset?: string;
/** Raw system prompt string (mutually exclusive with systemPromptPreset) */
systemPromptCustom?: string;
/** Additional text to append to the resolved system prompt */
systemPromptAppend?: string;
/** Which managed memory prompt mode to apply */
memoryPromptMode?: MemoryPromptMode;
/** Block labels to initialize (from default blocks) */
@@ -357,7 +355,6 @@ export async function createAgent(
// 1. If systemPromptCustom is provided, use it as-is
// 2. Otherwise, resolve systemPromptPreset to content
// 3. Reconcile to the selected managed memory mode
// 4. If systemPromptAppend is provided, append it to the result
let systemPromptContent: string;
if (options.systemPromptCustom) {
systemPromptContent = options.systemPromptCustom;
@@ -370,11 +367,6 @@ export async function createAgent(
options.memoryPromptMode ?? "standard",
);
// Append additional instructions if provided
if (options.systemPromptAppend) {
systemPromptContent = `${systemPromptContent}\n\n${options.systemPromptAppend}`;
}
// Create agent with inline memory blocks (LET-7101: single API call instead of N+1)
// - memory_blocks: new blocks to create inline
// - block_ids: references to existing blocks (for shared memory)

View File

@@ -111,7 +111,6 @@ export const CLI_FLAG_CATALOG = {
},
},
"system-custom": { parser: { type: "string" }, mode: "both" },
"system-append": { parser: { type: "string" }, mode: "headless" },
"memory-blocks": { parser: { type: "string" }, mode: "both" },
"block-value": {
parser: { type: "string", multiple: true },

View File

@@ -387,7 +387,6 @@ export async function handleHeadlessCommand(
const forceNew = values["new-agent"];
const systemPromptPreset = values.system;
const systemCustom = values["system-custom"];
const systemAppend = values["system-append"];
const embeddingModel = values.embedding;
const memoryBlocksJson = values["memory-blocks"];
const blockValueArgs = values["block-value"];
@@ -804,7 +803,6 @@ export async function handleHeadlessCommand(
parallelToolCalls: true,
systemPromptPreset,
systemPromptCustom: systemCustom,
systemPromptAppend: systemAppend,
memoryPromptMode: requestedMemoryPromptMode,
initBlocks,
baseTools,

View File

@@ -492,7 +492,6 @@ async function main(): Promise<void> {
const specifiedModel = values.model ?? undefined;
const systemPromptPreset = values.system ?? undefined;
const systemCustom = values["system-custom"] ?? undefined;
// Note: systemAppend is also parsed but only used in headless mode (headless.ts handles it)
const memoryBlocksJson = values["memory-blocks"] ?? undefined;
const specifiedToolset = values.toolset ?? undefined;
const skillsDirectory = values.skills ?? undefined;

View File

@@ -105,6 +105,22 @@ describe("shared CLI arg schema", () => {
expect(parsed.values["block-value"]).toEqual(["persona=hello"]);
});
test("rejects removed system-append flag in strict mode", () => {
expect(() =>
parseCliArgs(
preprocessCliArgs([
"node",
"script",
"-p",
"hello",
"--system-append",
"extra instructions",
]),
true,
),
).toThrow();
});
test("treats --import argument as a flag value, not prompt text", () => {
const parsed = parseCliArgs(
preprocessCliArgs([