Fimeg/letta-code
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: skip conversation API call for default conversation in /model and /reasoning (#1207)

Browse Source 
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
cthomas
2026-02-27 15:39:52 -08:00
committed by GitHub
parent 0d5dab198a
commit 81a826440c
1 changed files with 44 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

72
src/cli/App.tsx
View File

@@ -10912,19 +10912,27 @@ ${SYSTEM_REMINDER_CLOSE}
phase: "running",
});
const { updateConversationLLMConfig } = await import(
"../agent/modify"
);
const updatedConversation = await updateConversationLLMConfig(
conversationIdRef.current,
modelHandle,
model.updateArgs,
);
const conversationModelSettings = (
updatedConversation as {
model_settings?: AgentState["model_settings"] | null;
}
).model_settings;
// "default" is a virtual sentinel, not a real conversation object —
// skip the API call and fall through with undefined model_settings.
let conversationModelSettings:
| AgentState["model_settings"]
| null
| undefined;
if (conversationIdRef.current !== "default") {
const { updateConversationLLMConfig } = await import(
"../agent/modify"
);
const updatedConversation = await updateConversationLLMConfig(
conversationIdRef.current,
modelHandle,
model.updateArgs,
);
conversationModelSettings = (
updatedConversation as {
model_settings?: AgentState["model_settings"] | null;
}
).model_settings;
}
// The API may not echo reasoning_effort back, so populate it from
// model.updateArgs as a reliable fallback.
@@ -11610,21 +11618,29 @@ ${SYSTEM_REMINDER_CLOSE}
const cmd = commandRunner.start("/reasoning", "Setting reasoning...");
try {
const { updateConversationLLMConfig } = await import(
"../agent/modify"
);
const updatedConversation = await updateConversationLLMConfig(
conversationIdRef.current,
desired.modelHandle,
{
reasoning_effort: desired.effort,
},
);
const conversationModelSettings = (
updatedConversation as {
model_settings?: AgentState["model_settings"] | null;
}
).model_settings;
// "default" is a virtual sentinel, not a real conversation object —
// skip the API call and fall through with undefined model_settings.
let conversationModelSettings:
| AgentState["model_settings"]
| null
| undefined;
if (conversationIdRef.current !== "default") {
const { updateConversationLLMConfig } = await import(
"../agent/modify"
);
const updatedConversation = await updateConversationLLMConfig(
conversationIdRef.current,
desired.modelHandle,
{
reasoning_effort: desired.effort,
},
);
conversationModelSettings = (
updatedConversation as {
model_settings?: AgentState["model_settings"] | null;
}
).model_settings;
}
const resolvedReasoningEffort =
deriveReasoningEffort(
conversationModelSettings,