Fimeg/letta-code
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: show selector instead of silently creating agent when LRU retrieval fails (#471)

Browse Source 
Co-authored-by: Letta <noreply@letta.com>
This commit is contained in:
Charles Packer
2026-01-05 17:49:06 -08:00
committed by GitHub
parent b35e5e948f
commit ff62233fa3
1 changed files with 25 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
src/index.ts
View File

@@ -936,7 +936,10 @@ async function main(): Promise<void> {
await client.agents.retrieve(localProjectSettings.lastAgent);
resumingAgentId = localProjectSettings.lastAgent;
} catch {
// Agent no longer exists, will create new
// LRU agent doesn't exist (wrong org, deleted, etc.)
// Show selector instead of silently creating a new agent
setLoadingState("selecting_global");
return;
}
}
@@ -946,7 +949,9 @@ async function main(): Promise<void> {
await client.agents.retrieve(settings.lastAgent);
resumingAgentId = settings.lastAgent;
} catch {
// Agent no longer exists
// Global agent doesn't exist - show selector
setLoadingState("selecting_global");
return;
}
}
@@ -1049,33 +1054,34 @@ async function main(): Promise<void> {
}
// Priority 4: Try to resume from project settings LRU (.letta/settings.local.json)
if (!agent) {
await settingsManager.loadLocalProjectSettings();
const localProjectSettings =
settingsManager.getLocalProjectSettings();
if (localProjectSettings?.lastAgent) {
try {
agent = await client.agents.retrieve(
localProjectSettings.lastAgent,
);
// console.log(`Resuming project agent ${localProjectSettings.lastAgent}...`);
} catch (error) {
console.error(
`Project agent ${localProjectSettings.lastAgent} not found (error: ${JSON.stringify(error)}), creating new one...`,
);
}
// Note: If LRU retrieval failed in early validation, we already showed selector and returned
// This block handles the case where we have a valid resumingAgentId from early validation
if (!agent && resumingAgentId) {
try {
agent = await client.agents.retrieve(resumingAgentId);
} catch (error) {
// Agent disappeared between validation and now - show selector
console.error(
`Agent ${resumingAgentId} not found (error: ${JSON.stringify(error)})`,
);
setLoadingState("selecting_global");
return;
}
}
// Priority 6: Try to reuse global lastAgent if --continue flag is passed
// Note: If global lastAgent retrieval failed in early validation (with --continue),
// we already showed selector and returned. This is a safety fallback.
if (!agent && continueSession && settings.lastAgent) {
try {
agent = await client.agents.retrieve(settings.lastAgent);
// console.log(`Continuing previous agent ${settings.lastAgent}...`);
} catch (error) {
// Agent disappeared - show selector instead of silently creating
console.error(
`Previous agent ${settings.lastAgent} not found (error: ${JSON.stringify(error)}), creating new one...`,
`Previous agent ${settings.lastAgent} not found (error: ${JSON.stringify(error)})`,
);
setLoadingState("selecting_global");
return;
}
}