Fimeg/letta-server
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: remove default persona/human from memgpt configure and add functionality for modifying humans/presets more clearly (#1253)

Browse Source
This commit is contained in:
Sarah Wooders
2024-04-15 12:25:49 -07:00
committed by GitHub
parent 22e52dc1bc
commit 518437fa02
2 changed files with 44 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

73
memgpt/cli/cli_config.py
View File

@@ -866,36 +866,6 @@ def configure_embedding_endpoint(config: MemGPTConfig, credentials: MemGPTCreden
return embedding_endpoint_type, embedding_endpoint, embedding_dim, embedding_model
def configure_cli(config: MemGPTConfig, credentials: MemGPTCredentials):
# set: preset, default_persona, default_human, default_agent``
from memgpt.presets.presets import preset_options
# preset
default_preset = config.preset if config.preset and config.preset in preset_options else None
preset = questionary.select("Select default preset:", preset_options, default=default_preset).ask()
if preset is None:
raise KeyboardInterrupt
# persona
personas = [os.path.basename(f).replace(".txt", "") for f in utils.list_persona_files()]
default_persona = config.persona if config.persona and config.persona in personas else None
persona = questionary.select("Select default persona:", personas, default=default_persona).ask()
if persona is None:
raise KeyboardInterrupt
# human
humans = [os.path.basename(f).replace(".txt", "") for f in utils.list_human_files()]
default_human = config.human if config.human and config.human in humans else None
human = questionary.select("Select default human:", humans, default=default_human).ask()
if human is None:
raise KeyboardInterrupt
# TODO: figure out if we should set a default agent or not
agent = None
return preset, persona, human, agent
def configure_archival_storage(config: MemGPTConfig, credentials: MemGPTCredentials):
# Configure archival storage backend
archival_storage_options = ["postgres", "chroma"]
@@ -991,10 +961,6 @@ def configure():
config=config,
credentials=credentials,
)
default_preset, default_persona, default_human, default_agent = configure_cli(
config=config,
credentials=credentials,
)
archival_storage_type, archival_storage_uri, archival_storage_path = configure_archival_storage(
config=config,
credentials=credentials,
@@ -1025,10 +991,6 @@ def configure():
embedding_dim=embedding_dim,
embedding_model=embedding_model,
),
# cli configs
preset=default_preset,
persona=default_persona,
human=default_human,
# storage
archival_storage_type=archival_storage_type,
archival_storage_uri=archival_storage_uri,
@@ -1051,7 +1013,6 @@ def configure():
user_id = uuid.UUID(config.anon_clientid)
user = User(
id=uuid.UUID(config.anon_clientid),
default_agent=default_agent,
)
if ms.get_user(user_id):
# update user
@@ -1176,9 +1137,28 @@ def add(
with open(filename, "r") as f:
text = f.read()
if option == "persona":
ms.add_persona(PersonaModel(name=name, text=text, user_id=user_id))
persona = ms.get_persona(name=name, user_id=user_id)
if persona:
# config if user wants to overwrite
if not questionary.confirm(f"Persona {name} already exists. Overwrite?").ask():
return
persona.text = text
ms.update_persona(persona)
else:
persona = PersonaModel(name=name, text=text, user_id=user_id)
ms.add_persona(persona)
elif option == "human":
ms.add_human(HumanModel(name=name, text=text, user_id=user_id))
human = ms.get_human(name=name, user_id=user_id)
if human:
# config if user wants to overwrite
if not questionary.confirm(f"Human {name} already exists. Overwrite?").ask():
return
human.text = text
ms.update_human(human)
else:
human = HumanModel(name=name, text=text, user_id=user_id)
ms.add_human(HumanModel(name=name, text=text, user_id=user_id))
elif option == "preset":
assert filename, "Must specify filename for preset"
create_preset_from_file(filename, name, user_id, ms)
@@ -1228,15 +1208,22 @@ def delete(option: str, name: str):
ms.delete_agent(agent_id=agent.id)
elif option == "human":
human = ms.get_human(name=name, user_id=user_id)
assert human is not None, f"Human {name} does not exist"
ms.delete_human(name=name, user_id=user_id)
elif option == "persona":
persona = ms.get_persona(name=name, user_id=user_id)
assert persona is not None, f"Persona {name} does not exist"
ms.delete_persona(name=name, user_id=user_id)
assert ms.get_persona(name=name, user_id=user_id) is None, f"Persona {name} still exists"
elif option == "preset":
preset = ms.get_preset(name=name, user_id=user_id)
assert preset is not None, f"Preset {name} does not exist"
ms.delete_preset(name=name, user_id=user_id)
else:
raise ValueError(f"Option {option} not implemented")
typer.secho(f"Deleted source '{name}'", fg=typer.colors.GREEN)
typer.secho(f"Deleted {option} '{name}'", fg=typer.colors.GREEN)
except Exception as e:
typer.secho(f"Failed to deleted source '{name}'\n{e}", fg=typer.colors.RED)
typer.secho(f"Failed to delete {option}'{name}'\n{e}", fg=typer.colors.RED)

14
memgpt/metadata.py
View File

@@ -497,6 +497,20 @@ class MetadataStore:
session.query(SourceModel).filter(SourceModel.id == source.id).update(vars(source))
session.commit()
@enforce_types
def update_human(self, human: HumanModel):
with self.session_maker() as session:
session.add(human)
session.commit()
session.refresh(human)
@enforce_types
def update_persona(self, persona: PersonaModel):
with self.session_maker() as session:
session.add(persona)
session.commit()
session.refresh(persona)
@enforce_types
def delete_agent(self, agent_id: uuid.UUID):
with self.session_maker() as session: