fix: remove noisy sync log and fix timeout type (#8392)

base
This commit is contained in:
jnjpng
2026-01-07 12:44:57 -08:00
committed by Caren Thomas
parent 1d360cc239
commit 737d6e2550

View File

@@ -34,10 +34,10 @@ class EnvironmentVariableBase(OrmMetadataBase):
if self.value_enc and not self.value:
# ERROR: This should not happen - all code paths should populate value via async decryption
# Log error with stack trace to identify the caller that bypassed async decryption
logger.warning(
f"Sync decryption fallback triggered for env var key={self.key}. "
f"This indicates a code path that bypassed async decryption. Stack trace:\n{''.join(traceback.format_stack())}"
)
# logger.warning(
# f"Sync decryption fallback triggered for env var key={self.key}. "
# f"This indicates a code path that bypassed async decryption. Stack trace:\n{''.join(traceback.format_stack())}"
# )
# Decrypt value_enc -> value (for API responses)
plaintext = self.value_enc.get_plaintext()
if plaintext:
@@ -45,10 +45,10 @@ class EnvironmentVariableBase(OrmMetadataBase):
elif self.value and not self.value_enc:
# WARNING: This triggers sync encryption - should use async encryption where possible
# Log warning with stack trace to identify the caller
logger.warning(
f"Sync encryption fallback triggered for env var key={self.key}. "
f"This indicates a code path that bypassed async encryption. Stack trace:\n{''.join(traceback.format_stack())}"
)
# logger.warning(
# f"Sync encryption fallback triggered for env var key={self.key}. "
# f"This indicates a code path that bypassed async encryption. Stack trace:\n{''.join(traceback.format_stack())}"
# )
# Encrypt value -> value_enc (for backward compat when value is provided directly)
self.value_enc = Secret.from_plaintext(self.value)
return self