Fimeg/letta-server
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

chore: fix typo and improve MCP OAuth comments (#8629)

Browse Source 
- Fix typo "upate" -> "update" in TODO comments (mcp_manager.py, mcp_server_manager.py)
- Improve comments in OAuth callback handler to explain why MCPOAuthSession
  is used directly (callback is unauthenticated, manager requires actor)
- Clean up variable naming in callback handler

🐾 Generated with [Letta Code](https://letta.com)

Co-authored-by: Letta <noreply@letta.com>
This commit is contained in:
jnjpng
2026-01-12 16:31:57 -08:00
committed by Sarah Wooders
parent ab4ccfca31
commit 979062114c
3 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
letta/server/rest_api/routers/v1/tools.py
View File

@@ -859,21 +859,20 @@ async def mcp_oauth_callback(
error_msg = f"OAuth error: {error}"
if error_description:
error_msg += f" - {error_description}"
# Use the legacy MCPOAuthSession class to update status
legacy_session = MCPOAuthSession(oauth_session.id)
await legacy_session.update_session_status(OAuthSessionStatus.ERROR)
# Note: Using MCPOAuthSession directly because this callback is unauthenticated
# (called by OAuth provider) and the manager's update_oauth_session requires an actor
await MCPOAuthSession(oauth_session.id).update_session_status(OAuthSessionStatus.ERROR)
return {"status": "error", "message": error_msg}
if not code:
legacy_session = MCPOAuthSession(oauth_session.id)
await legacy_session.update_session_status(OAuthSessionStatus.ERROR)
await MCPOAuthSession(oauth_session.id).update_session_status(OAuthSessionStatus.ERROR)
return {"status": "error", "message": "Missing authorization code"}
# Store authorization code using the legacy session class
legacy_session = MCPOAuthSession(oauth_session.id)
success = await legacy_session.store_authorization_code(code, state)
# Store authorization code (using MCPOAuthSession since callback is unauthenticated)
session_handler = MCPOAuthSession(oauth_session.id)
success = await session_handler.store_authorization_code(code, state)
if not success:
await legacy_session.update_session_status(OAuthSessionStatus.ERROR)
await session_handler.update_session_status(OAuthSessionStatus.ERROR)
return {"status": "error", "message": "Failed to store authorization code"}
return {"status": "success", "message": "Authorization successful", "server_url": success.server_url}

2
letta/services/mcp_manager.py
View File

@@ -386,7 +386,7 @@ class MCPManager:
)
oauth_sessions = result.scalars().all()
# TODO: @jnjpng we should upate sessions in bulk
# TODO: @jnjpng we should update sessions in bulk
for oauth_session in oauth_sessions:
oauth_session.server_id = mcp_server.id
await oauth_session.update_async(db_session=session, actor=actor, no_commit=True)

2
letta/services/mcp_server_manager.py
View File

@@ -482,7 +482,7 @@ class MCPServerManager:
)
oauth_sessions = result.scalars().all()
# TODO: @jnjpng we should upate sessions in bulk
# TODO: @jnjpng we should update sessions in bulk
for oauth_session in oauth_sessions:
oauth_session.server_id = mcp_server.id
await oauth_session.update_async(db_session=session, actor=actor, no_commit=True)