Fimeg/letta-server
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Revert "feat: add statement_timeout to SQLAlchemy OTEL spans" (#9224)

Browse Source 
Revert "feat: add statement_timeout to SQLAlchemy OTEL spans (#9220)"

This reverts commit b8f3ed334f29b11d21d391e46c06224fa259399e.
This commit is contained in:
Kian Jones
2026-01-30 16:10:37 -08:00
committed by Caren Thomas
parent 630c147b13
commit ddd1a11a93
1 changed files with 0 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
letta/otel/sqlalchemy_instrumentation.py
View File

@@ -120,24 +120,11 @@ def _instrument_engine_events(engine: Engine) -> None:
if isinstance(engine, AsyncEngine):
engine = engine.sync_engine
def checkout(dbapi_conn, connection_record, connection_proxy):
"""Query and cache statement_timeout on connection checkout."""
try:
cursor = dbapi_conn.cursor()
cursor.execute("SHOW statement_timeout")
result = cursor.fetchone()
connection_record.info["statement_timeout"] = result[0] if result else None
cursor.close()
except Exception:
connection_record.info["statement_timeout"] = None
def before_cursor_execute(conn, cursor, statement, parameters, context, executemany):
"""Track cursor execution start."""
if not _config["enabled"]:
return
statement_timeout = conn.info.get("statement_timeout")
# Store context for the after event
context._sync_instrumentation_span = _create_sync_db_span(
operation_type="cursor_execute",
@@ -145,7 +132,6 @@ def _instrument_engine_events(engine: Engine) -> None:
additional_attrs={
"db.executemany": executemany,
"db.connection.info": str(conn.info),
"db.statement_timeout": statement_timeout,
},
)
@@ -177,7 +163,6 @@ def _instrument_engine_events(engine: Engine) -> None:
context._sync_instrumentation_span = None
# Register engine events
event.listen(engine.pool, "checkout", checkout)
event.listen(engine, "before_cursor_execute", before_cursor_execute)
event.listen(engine, "after_cursor_execute", after_cursor_execute)
event.listen(engine, "handle_error", handle_cursor_error)
@@ -185,7 +170,6 @@ def _instrument_engine_events(engine: Engine) -> None:
# Store listeners for cleanup
_instrumentation_state["engine_listeners"].extend(
[
(engine.pool, "checkout", checkout),
(engine, "before_cursor_execute", before_cursor_execute),
(engine, "after_cursor_execute", after_cursor_execute),
(engine, "handle_error", handle_cursor_error),