Fimeg/letta-server
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

feat: generate otid when using input field on message send (#5990)

Browse Source 
* base

* try this out

* plz

* fix

---------

Co-authored-by: Letta Bot <noreply@letta.com>
This commit is contained in:
jnjpng
2025-11-05 15:35:43 -08:00
committed by Caren Thomas
parent 6943b68288
commit e2774c07c6
2 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
letta/schemas/letta_request.py
View File

@@ -1,3 +1,4 @@
import uuid
from typing import List, Optional, Union
from pydantic import BaseModel, Field, HttpUrl, field_validator, model_validator
@@ -73,7 +74,7 @@ class LettaRequest(BaseModel):
# input can be either a string or List[LettaMessageContentUnion]
if self.input is not None:
# Both str and List[LettaMessageContentUnion] are valid content types for MessageCreate
self.messages = [MessageCreate(role=MessageRole.user, content=self.input)]
self.messages = [MessageCreate(role=MessageRole.user, content=self.input, otid=str(uuid.uuid4()))]
return self

19
tests/sdk_v1/integration/integration_test_send_message.py
View File

@@ -240,6 +240,7 @@ def assert_greeting_with_assistant_message_response(
streaming: bool = False,
token_streaming: bool = False,
from_db: bool = False,
input: bool = False,
) -> None:
"""
Asserts that the messages list follows the expected sequence:
@@ -258,7 +259,11 @@ def assert_greeting_with_assistant_message_response(
index = 0
if from_db:
assert isinstance(messages[index], UserMessage)
assert messages[index].otid == USER_MESSAGE_OTID
# if messages are passed through the input parameter, the otid is generated on the server side
if not input:
assert messages[index].otid == USER_MESSAGE_OTID
else:
assert messages[index].otid is not None
index += 1
# Agent Step 1
@@ -2374,11 +2379,11 @@ def test_input_parameter_basic(
)
assert_contains_run_id(response.messages)
assert_greeting_with_assistant_message_response(response.messages, llm_config=llm_config)
assert_greeting_with_assistant_message_response(response.messages, llm_config=llm_config, input=True)
messages_from_db_page = client.agents.messages.list(agent_id=agent_state.id, after=last_message.id if last_message else None)
messages_from_db = messages_from_db_page.items
assert_first_message_is_user_message(messages_from_db)
assert_greeting_with_assistant_message_response(messages_from_db, from_db=True, llm_config=llm_config)
assert_greeting_with_assistant_message_response(messages_from_db, from_db=True, llm_config=llm_config, input=True)
@pytest.mark.parametrize(
@@ -2408,11 +2413,11 @@ def test_input_parameter_streaming(
assert_contains_step_id(chunks)
assert_contains_run_id(chunks)
messages = accumulate_chunks(chunks)
assert_greeting_with_assistant_message_response(messages, streaming=True, llm_config=llm_config)
assert_greeting_with_assistant_message_response(messages, streaming=True, llm_config=llm_config, input=True)
messages_from_db_page = client.agents.messages.list(agent_id=agent_state.id, after=last_message.id if last_message else None)
messages_from_db = messages_from_db_page.items
assert_contains_run_id(messages_from_db)
assert_greeting_with_assistant_message_response(messages_from_db, from_db=True, llm_config=llm_config)
assert_greeting_with_assistant_message_response(messages_from_db, from_db=True, llm_config=llm_config, input=True)
@pytest.mark.parametrize(
@@ -2441,10 +2446,10 @@ def test_input_parameter_async(
messages_page = client.runs.messages.list(run_id=run.id)
messages = messages_page.items
assert_greeting_with_assistant_message_response(messages, from_db=True, llm_config=llm_config)
assert_greeting_with_assistant_message_response(messages, from_db=True, llm_config=llm_config, input=True)
messages_from_db_page = client.agents.messages.list(agent_id=agent_state.id, after=last_message.id if last_message else None)
messages_from_db = messages_from_db_page.items
assert_greeting_with_assistant_message_response(messages_from_db, from_db=True, llm_config=llm_config)
assert_greeting_with_assistant_message_response(messages_from_db, from_db=True, llm_config=llm_config, input=True)
def test_input_and_messages_both_provided_error(