2ffef0fb31
* fix(core): handle git memory label prefix collisions in filesystem view Prevent context window preview crashes when a block label is both a leaf and a prefix (e.g. system/human and system/human/context) by rendering a node as both file and directory. Add regression test. 👾 Generated with [Letta Code](https://letta.com) Co-Authored-By: Letta <noreply@letta.com> * fix(core): parse git-backed core memory in context window preview ContextWindowCalculator.extract_system_components now detects git-backed memory rendering (<memory_filesystem> and <system/...> tags) when <memory_blocks> wrapper is absent, so core_memory is populated in the context preview. Add regression tests. 👾 Generated with [Letta Code](https://letta.com) Co-Authored-By: Letta <noreply@letta.com> --------- Co-authored-by: Letta <noreply@letta.com>
256 lines
11 KiB
Python
256 lines
11 KiB
Python
from types import SimpleNamespace
|
|
|
|
import pytest
|
|
|
|
from letta.constants import CORE_MEMORY_LINE_NUMBER_WARNING
|
|
from letta.schemas.block import Block, FileBlock
|
|
from letta.schemas.enums import AgentType
|
|
from letta.schemas.memory import ChatMemory, Memory
|
|
|
|
|
|
def make_source(id_: str, name: str, description: str | None = None, instructions: str | None = None):
|
|
return SimpleNamespace(id=id_, name=name, description=description, instructions=instructions)
|
|
|
|
|
|
@pytest.fixture
|
|
def chat_memory():
|
|
return ChatMemory(persona="Chat Agent", human="User")
|
|
|
|
|
|
def test_chat_memory_init_and_utils(chat_memory: Memory):
|
|
assert chat_memory.get_block("persona").value == "Chat Agent"
|
|
assert chat_memory.get_block("human").value == "User"
|
|
assert set(chat_memory.list_block_labels()) == {"persona", "human"}
|
|
|
|
|
|
def test_memory_limit_validation(chat_memory: Memory):
|
|
with pytest.raises(ValueError):
|
|
ChatMemory(persona="x " * 50000, human="y " * 50000)
|
|
with pytest.raises(ValueError):
|
|
chat_memory.get_block("persona").value = "x " * 50000
|
|
|
|
|
|
def test_get_block_not_found(chat_memory: Memory):
|
|
with pytest.raises(KeyError):
|
|
chat_memory.get_block("missing")
|
|
|
|
|
|
def test_update_block_value_type_error(chat_memory: Memory):
|
|
with pytest.raises(ValueError):
|
|
chat_memory.update_block_value("persona", 123) # type: ignore[arg-type]
|
|
|
|
|
|
def test_update_block_value_success(chat_memory: Memory):
|
|
chat_memory.update_block_value("human", "Hi")
|
|
assert chat_memory.get_block("human").value == "Hi"
|
|
|
|
|
|
def test_compile_standard_blocks_metadata_and_values():
|
|
m = Memory(
|
|
agent_type=AgentType.memgpt_agent,
|
|
blocks=[
|
|
Block(label="persona", value="I am P", limit=100, read_only=True),
|
|
Block(label="human", value="Hello", limit=100),
|
|
],
|
|
)
|
|
out = m.compile()
|
|
assert "<memory_blocks>" in out
|
|
assert "<persona>" in out and "</persona>" in out
|
|
assert "<human>" in out and "</human>" in out
|
|
assert "- read_only=true" in out
|
|
assert "- chars_current=6" in out # len("Hello")
|
|
|
|
|
|
def test_compile_line_numbered_blocks_sleeptime():
|
|
m = Memory(agent_type=AgentType.sleeptime_agent, blocks=[Block(label="notes", value="line1\nline2", limit=100)])
|
|
out = m.compile()
|
|
assert "<memory_blocks>" in out
|
|
# Without llm_config, should NOT show line numbers (backward compatibility)
|
|
assert CORE_MEMORY_LINE_NUMBER_WARNING not in out
|
|
assert "1→ line1" not in out and "2→ line2" not in out
|
|
assert "line1" in out and "line2" in out # Content should still be there
|
|
|
|
|
|
def test_compile_line_numbered_blocks_memgpt_v2():
|
|
m = Memory(agent_type=AgentType.memgpt_v2_agent, blocks=[Block(label="notes", value="a\nb", limit=100)])
|
|
out = m.compile()
|
|
# Without llm_config, should NOT show line numbers (backward compatibility)
|
|
assert "1→ a" not in out and "2→ b" not in out
|
|
assert "a" in out and "b" in out # Content should still be there
|
|
|
|
|
|
def test_compile_line_numbered_blocks_with_anthropic():
|
|
"""Test that line numbers appear when using Anthropic models."""
|
|
from letta.schemas.llm_config import LLMConfig
|
|
|
|
m = Memory(agent_type=AgentType.letta_v1_agent, blocks=[Block(label="notes", value="line1\nline2", limit=100)])
|
|
anthropic_config = LLMConfig(model="claude-3-sonnet-20240229", model_endpoint_type="anthropic", context_window=200000)
|
|
out = m.compile(llm_config=anthropic_config)
|
|
assert "<memory_blocks>" in out
|
|
assert CORE_MEMORY_LINE_NUMBER_WARNING in out
|
|
assert "1→ line1" in out and "2→ line2" in out
|
|
|
|
|
|
def test_compile_line_numbered_blocks_with_openai():
|
|
"""Test that line numbers do NOT appear when using OpenAI models."""
|
|
from letta.schemas.llm_config import LLMConfig
|
|
|
|
m = Memory(agent_type=AgentType.letta_v1_agent, blocks=[Block(label="notes", value="line1\nline2", limit=100)])
|
|
openai_config = LLMConfig(model="gpt-4", model_endpoint_type="openai", context_window=128000)
|
|
out = m.compile(llm_config=openai_config)
|
|
assert "<memory_blocks>" in out
|
|
assert CORE_MEMORY_LINE_NUMBER_WARNING not in out
|
|
assert "1→ line1" not in out and "2→ line2" not in out
|
|
assert "line1" in out and "line2" in out # Content should still be there
|
|
|
|
|
|
def test_compile_empty_returns_empty_string():
|
|
m = Memory(agent_type=AgentType.memgpt_agent, blocks=[])
|
|
assert m.compile() == ""
|
|
|
|
|
|
def test_tool_usage_rules_inclusion_and_order():
|
|
m = Memory(agent_type=AgentType.memgpt_agent, blocks=[Block(label="a", value="b", limit=100)])
|
|
rules = Block(label="tool_usage_rules", value="RVAL", description="RDESCR", limit=100)
|
|
out = m.compile(tool_usage_rules=rules)
|
|
assert "<tool_usage_rules>" in out
|
|
assert "RDESCR" in out and "RVAL" in out
|
|
assert out.index("</memory_blocks>") < out.index("<tool_usage_rules>")
|
|
|
|
|
|
def test_directories_common_includes_files_and_metadata():
|
|
src = make_source("src1", "project", "Sdesc", "Sinst")
|
|
fb = FileBlock(label="fileA", value="data", limit=100, file_id="f1", source_id="src1", is_open=True, read_only=True)
|
|
m = Memory(agent_type=AgentType.memgpt_agent, blocks=[Block(label="x", value="y", limit=10)], file_blocks=[fb])
|
|
out = m.compile(sources=[src], max_files_open=3)
|
|
assert "<directories>" in out and "</directories>" in out
|
|
assert "<file_limits>" in out
|
|
assert "- current_files_open=1" in out and "- max_files_open=3" in out
|
|
assert "<description>Sdesc</description>" in out
|
|
assert "<instructions>Sinst</instructions>" in out
|
|
assert 'name="fileA"' in out
|
|
assert "- read_only=true" in out
|
|
assert "<value>\ndata\n</value>" in out
|
|
|
|
|
|
def test_directories_common_omits_empty_value():
|
|
src = make_source("src1", "project")
|
|
fb = FileBlock(label="fileA", value="", limit=100, file_id="f1", source_id="src1", is_open=True)
|
|
m = Memory(agent_type=AgentType.memgpt_agent, blocks=[], file_blocks=[fb])
|
|
out = m.compile(sources=[src])
|
|
assert "<directories>" in out
|
|
assert "<value>" not in out # omitted for empty value in common path
|
|
|
|
|
|
def test_directories_react_nested_label_and_status_counts():
|
|
src = make_source("src1", "project")
|
|
fb1 = FileBlock(label="fileA", value="content", limit=100, file_id="f1", source_id="src1", is_open=True)
|
|
fb2 = FileBlock(label="fileB", value="", limit=100, file_id="f2", source_id="src1", is_open=True)
|
|
m = Memory(agent_type=AgentType.react_agent, blocks=[Block(label="ignore", value="zz", limit=5)], file_blocks=[fb1, fb2])
|
|
out = m.compile(sources=[src], max_files_open=5)
|
|
assert "<memory_blocks>" not in out
|
|
assert "<directories>" in out
|
|
assert '<file status="open">' in out
|
|
assert '<file status="closed">' in out
|
|
assert "<fileA>" in out and "</fileA>" in out
|
|
assert "- current_files_open=1" in out
|
|
|
|
|
|
def test_directories_file_limits_absent_when_none():
|
|
src = make_source("src1", "project")
|
|
fb = FileBlock(label="fileA", value="x", limit=100, file_id="f1", source_id="src1", is_open=True)
|
|
m = Memory(agent_type=AgentType.memgpt_agent, blocks=[], file_blocks=[fb])
|
|
out = m.compile(sources=[src], max_files_open=None)
|
|
assert "<directories>" in out
|
|
assert "<file_limits>" not in out
|
|
|
|
|
|
def test_agent_type_as_string_equivalent_behavior():
|
|
src = make_source("src1", "project")
|
|
m = Memory(agent_type="workflow_agent", blocks=[])
|
|
out = m.compile(sources=[src])
|
|
assert "<directories>" in out
|
|
assert "<memory_blocks>" not in out
|
|
|
|
|
|
def test_file_blocks_duplicates_pruned_and_warning(caplog):
|
|
caplog.clear()
|
|
src = make_source("s", "n")
|
|
fb1 = FileBlock(label="dup", value="a", limit=100, file_id="f1", source_id="s", is_open=True)
|
|
fb2 = FileBlock(label="dup", value="b", limit=100, file_id="f2", source_id="s", is_open=True)
|
|
with caplog.at_level("WARNING", logger="letta.schemas.memory"):
|
|
m = Memory(agent_type=AgentType.memgpt_agent, blocks=[], file_blocks=[fb1, fb2])
|
|
out = m.compile(sources=[src])
|
|
assert caplog.records
|
|
assert any("Duplicate block labels found" in r.message for r in caplog.records)
|
|
assert out.count('name="dup"') == 1
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_compile_async_matches_sync():
|
|
m = Memory(agent_type=AgentType.memgpt_agent, blocks=[Block(label="a", value="b", limit=10)])
|
|
assert await m.compile_async() == m.compile()
|
|
|
|
|
|
def test_prompt_template_deprecated_noop():
|
|
m = Memory(agent_type=AgentType.memgpt_agent, blocks=[])
|
|
m.set_prompt_template("foo")
|
|
assert m.get_prompt_template() == "foo"
|
|
|
|
|
|
def test_sources_without_descriptions_or_instructions():
|
|
src = make_source("src1", "project", None, None)
|
|
fb = FileBlock(label="fileA", value="data", limit=100, file_id="f1", source_id="src1", is_open=True)
|
|
m = Memory(agent_type=AgentType.memgpt_agent, blocks=[], file_blocks=[fb])
|
|
out = m.compile(sources=[src])
|
|
assert "<description>" not in out or "<description></description>" not in out
|
|
assert "<instructions>" not in out
|
|
|
|
|
|
def test_read_only_metadata_in_file_and_block():
|
|
src = make_source("src1", "project")
|
|
fb = FileBlock(label="fileA", value="data", limit=100, file_id="f1", source_id="src1", is_open=True, read_only=True)
|
|
m = Memory(agent_type=AgentType.memgpt_agent, blocks=[Block(label="x", value="y", limit=10, read_only=True)], file_blocks=[fb])
|
|
out = m.compile(sources=[src])
|
|
assert out.count("- read_only=true") >= 2
|
|
|
|
|
|
def test_current_files_open_counts_truthy_only():
|
|
src = make_source("src1", "project")
|
|
fb1 = FileBlock(label="fileA", value="data", limit=100, file_id="f1", source_id="src1", is_open=True)
|
|
fb2 = FileBlock(label="fileB", value="", limit=100, file_id="f2", source_id="src1", is_open=False)
|
|
fb3 = FileBlock(label="fileC", value="", limit=100, file_id="f3", source_id="src1", is_open=False)
|
|
m = Memory(agent_type=AgentType.react_agent, blocks=[], file_blocks=[fb1, fb2, fb3])
|
|
out = m.compile(sources=[src], max_files_open=10)
|
|
assert "- current_files_open=1" in out
|
|
|
|
|
|
def test_compile_git_memory_filesystem_handles_leaf_directory_collisions():
|
|
"""Git memory filesystem rendering should tolerate label prefix collisions.
|
|
|
|
Example collisions:
|
|
- leaf at "system" and children under "system/..."
|
|
- leaf at "system/human" and children under "system/human/..."
|
|
|
|
These occur naturally in git-backed memory where both index-like blocks and
|
|
nested blocks can exist.
|
|
"""
|
|
|
|
m = Memory(
|
|
agent_type=AgentType.letta_v1_agent,
|
|
git_enabled=True,
|
|
blocks=[
|
|
Block(label="system", value="root", limit=100),
|
|
Block(label="system/human", value="human index", limit=100),
|
|
Block(label="system/human/context", value="context", limit=100),
|
|
],
|
|
)
|
|
|
|
out = m.compile()
|
|
|
|
# Should include the filesystem view and not raise.
|
|
assert "<memory_filesystem>" in out
|
|
assert "system/" in out
|
|
assert "system.md" in out
|
|
assert "human.md" in out
|